Christopher Oliver wrote:

Sylvain Wallez wrote:

- we need a "popStackFrame()" method, since once a component has been executed successfully and execution continues in its following siblings, it should no longer appear in the stack trace


The idea is that this stack trace is created during exception processing:

try {
do whatever
} catch (Exception e) {
Cocoon.addCocoonStackTrace("failed to do whatever", "comp", "method", uri, line, column);
throw e;
}


Thus, during normal processing there is no overhead. That's why there's no popStackFrame().


HUGE +1 to no overhead. And, if it helps, my thinking on adding traces to TreeProcessor was among the same lines with one difference: I thought we can store this stacktrace in the exception itself. What do you think?

Vadim


Reply via email to