After Cheche's bug report I had a look at NetUtils. Though Ugo fixed it with a quick fix, it does not really solve the problem as a test with the updated NetUtilsTestCase and the NetUtils before my latest commit can easily show.
My problem is that there are many problems in different places in the code:
1. o.a.commons.lang.StringUtils.split() behaves strange in that way that o.a.com.l.SU.split("", "/") return an empty String[]
while
o.a.coc.u.SU.split("", "/") returns String[] {""} which is what I would expect.
Also
o.a.com.l.SU.split("/", "/") returns empty String[].
This means the iteration over the string array can never really work with o.a.commons.lang.StringUtils.
=> reverted that change.
2. our Tokenizer behaves strange in one case:
o.a.coc.u.SU.split("/", "/") => new Tokenizer("/", "/", false) => tokenizer.countTokens() = 2 => but tokenizer.hasMoreTokens() returns true only once => leads to String[] {"", null} while it should be String[] {"", ""}
3. while the Tokenizer correctly works on "/../" the NetUtils.normalize() method has a problem with it:
result of split/tokenize: String[] {"", "..", ""} result of normalize(): ""
What about using ORO regexp for these things? When I first wrote I was not really much into regular expressions, but now I do think it makes sense to use them, these guys spent a lot of time making sure those things don't happen.
-- Stefano.
smime.p7s
Description: S/MIME Cryptographic Signature
