And what would happen to:

Map params = new java.util.HashMap();
params.put("username", this.defaultUser);
params.put("password", this.defaultPass);
Source cSource = this.resolver.resolveURI(source, null, params);


Like it or not, there are still many places the Locator pattern is valid. Using Selectors, for example. You can't solve *everything* with direct injection.

On Wed, 20 Oct 2004, Stefano Mazzocchi wrote:

Unico Hommes wrote:

I've often thought that the signature of the setup() method was wrong. The src parameter is passed as a String, the component is free to interpret it as anything it wishes. But I think this parameter was really only meant to ever be interpreted as a Source object. So instead of setup(SourceResolver resolver, Map om, String src, Parameters pars) the method should be setup(Source source, Map om, Parameters pars). That also unambiguously defines the meaning of the src attribute.

Amen. Too bad this is the most back-incompatible change you can think of. :-(

--
Stefano.


Reply via email to