One comment about this change: this would break compatibility with
version 1.1 and the clirr plugin flags this as an error. However we
already have clirr errors in the report since the 2 protected fields eDA
and windowSize have been removed from the now deprecated
DescriptiveStatisticsImpl class and since the 10 protected fields
geoMean, max, mean, min, n, secondMoment, sum , sumLog, sumsq and
variance from the now deprecated SummaryStatisticsImpl class.
Luc
Luc Maisonobe wrote:
I am performing a new pass on removing findbugs warnings.
One warning occurs in both BigMatrixImpl and RealMatrixImpl, it is about
the protected field TOO_SMALL that according to findbugs should be
final. I agree with it. This field is also protected whereas I would
prefer it to be private. It is used in only once in each class.
I don't see the point for a protected non final field. Is it intended to
be changed by derived classes ? Then shouln't there be a method for that
? Would you mind if I change the field to private final ?
Luc
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
