On 1/12/08, Luc Maisonobe <[EMAIL PROTECTED]> wrote: > One comment about this change: this would break compatibility with > version 1.1 and the clirr plugin flags this as an error. <snip/>
That was my initial reaction as well when I read your first note (below). In general, we try to avoid incompatible changes (there are specific cases where we can attempt to push for exceptions, such as blatant bugs and/or v0.x releases). About the clirr errors you mention in the following paragraph, I suspect they will come up for discussion at the next release unless they are addressed or its a major release etc. -Rahul > However we > already have clirr errors in the report since the 2 protected fields eDA > and windowSize have been removed from the now deprecated > DescriptiveStatisticsImpl class and since the 10 protected fields > geoMean, max, mean, min, n, secondMoment, sum , sumLog, sumsq and > variance from the now deprecated SummaryStatisticsImpl class. > > Luc > > Luc Maisonobe wrote: > > I am performing a new pass on removing findbugs warnings. > > One warning occurs in both BigMatrixImpl and RealMatrixImpl, it is about > > the protected field TOO_SMALL that according to findbugs should be > > final. I agree with it. This field is also protected whereas I would > > prefer it to be private. It is used in only once in each class. > > > > I don't see the point for a protected non final field. Is it intended to > > be changed by derived classes ? Then shouln't there be a method for that > > ? Would you mind if I change the field to private final ? > > > > Luc > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
