> Please review esspecially the license stuff which we discussed > recently before applying.
I have it applied here locally and are ready for a commit. I did change a few things though. I've removed the attribution from the class files as we don't do author tags either. I would think the attribution in the NOTICE file should be enough. Or we add something more along the lines of "based on the code from the jrpm project". I've also did some other renaming and nitpicking The one that still bugs me a bit is the ASL 1.1 vs 2.0 thing. IIRC there was a resolution that we are not supposed to commit ASL 1.1 code anymore. And having both licenses in the LICENSE file is also suboptimal IMO. Could we maybe ask the jrpm project whether upgrading the license to ASL 2.0 would be an option? Would make things a little cleaner IMO. cheers -- Torsten --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
