On Wed, Jan 14, 2009 at 1:07 AM, Phil Steitz <phil.ste...@gmail.com> wrote: > Mark Thomas wrote: >> >> Folks, >> >> DBCP seems to have been fairly quiet for a while. In recent days I have >> hit >> / seen others hit various issues including: >> - DBCP doesn't build on a 1.6 JVM >> - Tomcat 5/6 can't build on a 1.6 JVM because it depends on building DBCP >> - Tomcat trunk (the basis for 7) requires building on a 1.6 JVM >> - One of the major reasons Gump builds on a 1.5 JVM is DBCP >> >> Putting to one side that the root cause is incompatible changes in the JDK >> (grr) there is a patch in Jira (DBCP-191) to address this issue. >> >> I'd like to at least get these changes into svn with the intention of >> moving >> towards a DBCP (1.3?) release. >> >> Any objections or anything I need to be aware of before I start work? > > +1 as in will help. Closing all issues may require a pool release, which I > am also willing to help with. Trunk includes some significant enhancements > (managed connections) and behavior changes (repeated close is a no-op), so a > release from trunk should be 1.3. I have thought about backporting fixes > (especially DBCP-270, the fix for which may resolve some case of DBCP-44) > to get a 1.2.3 out while working on 1.3. I am OK pushing forward directly > to 1.3, but given severity of these issues and assuming we may drop 1.4 > support, it may be best to push out a 1.2.3 to address them. > Phil
On the issue of not building with JDBC 4.0 / 1.6 JDK (DBCP-191) and creating a compatible release with previous JDKs (1.4/1.5) then we should be able to set the source/target compiler options. The main issue would then be ensuring that other JDK 1.6 features didn't leak into the rest of the code base. DBCP seems to already have a mechanism in place that deals with the JDBC 2.0/3.0 incompatibilities with the source code being "marked up" and options in the ant build to detect the JDBC version and comment out portions of the code. We could extend this to the JDBC 4.0 features. This should enable it to be tested on previous JDK versions, even if the release is created using JDK 1.6. I am willing to try to get this working this week - I'm a bit short on time, but hopefully by the weekend. Niall >> Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
