Hi Phil, Phil Steitz wrote:
> I have prepared release candidates for DBCP 1.3 and 1.4. Please all > interested parties have a look and test. If all goes well, I will > kick off a release VOTE based on these artifacts in the next couple > of days. I see these as really two sets of artifacts associated > with one release, so I am inclined to just do one VOTE including > both versions. If anyone disagrees with this, please speak up. I > am happy to run two VOTEs. > > 1.3 (JDBC 3) version: > http://people.apache.org/~psteitz/dbcp-1.3-rc1 > http://people.apache.org/~psteitz/dbcp-1.3-rc1/site > http://people.apache.org/~psteitz/dbcp-1.3-rc1/maven > http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC1/ Like Nial I changed geronimo-jta_1.1_spec to version 1.1. My compiler zoo fails though for blackdown-jdk-1.4.2.03, jrockit-jdk-1.4.2.16 and sun- jdk-1.4.2.19. IMHO you must update the xerces version to a release that contains the driver implementation in the Java-SPI (META-INF/services): ========================== %< ================================ Test set: org.apache.commons.jocl.TestJOCLContentHandler ------------------------------------------------------------------------------- Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.047 sec <<< FAILURE! testObject(org.apache.commons.jocl.TestJOCLContentHandler) Time elapsed: 0.006 sec testPrimitives(org.apache.commons.jocl.TestJOCLContentHandler) Time elapsed: 0 sec testParse(org.apache.commons.jocl.TestJOCLContentHandler) Time elapsed: 0.028 sec <<< ERROR! org.xml.sax.SAXException: System property org.xml.sax.driver not specified at org.xml.sax.helpers.XMLReaderFactory.createXMLReader(XMLReaderFactory.java:90) at org.apache.commons.jocl.JOCLContentHandler.parse(JOCLContentHandler.java:339) at org.apache.commons.jocl.JOCLContentHandler.parse(JOCLContentHandler.java:271) at org.apache.commons.jocl.TestJOCLContentHandler.testParse(TestJOCLContentHandler.java:255) ========================== %< ================================ Using IBM-JDK 1.4.2.13 the build and all tests with Ant 1.6.5 succeed, but I get nevertheless those exceptions, I do not see, when running the other JDKs with Maven: ========================== %< ================================ [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: DBCP object created 2009-12-08 23:03:07 by the following code was never closed: [junit] at org.apache.commons.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java:138) [junit] at org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:81) [junit] at org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) [junit] at org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044) [junit] at org.apache.commons.dbcp.TestAbandonedBasicDataSource.testAbandoned(TestAbandonedBasicDataSource.java:65) ========================== %< ================================ ========================== %< ================================ [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: DBCP object created 2009-12-08 23:03:07 by the following code was never closed: [junit] at org.apache.commons.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java:138) [junit] at org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:81) [junit] at org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) [junit] at org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044) [junit] at org.apache.commons.dbcp.TestBasicDataSource.getConnection(TestBasicDataSource.java:44) [junit] at org.apache.commons.dbcp.TestAbandonedBasicDataSource.testAbandonedClose(TestAbandonedBasicDataSource.java:75) ========================== %< ================================ ========================== %< ================================ [junit] org.apache.commons.dbcp.AbandonedTrace$AbandonedObjectException: DBCP object created 2009-12-08 23:03:07 by the following code was never closed: [junit] at org.apache.commons.dbcp.AbandonedTrace.setStackTrace(AbandonedTrace.java:138) [junit] at org.apache.commons.dbcp.AbandonedObjectPool.borrowObject(AbandonedObjectPool.java:81) [junit] at org.apache.commons.dbcp.PoolingDataSource.getConnection(PoolingDataSource.java:106) [junit] at org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044) [junit] at org.apache.commons.dbcp.TestBasicDataSource.getConnection(TestBasicDataSource.java:44) [junit] at org.apache.commons.dbcp.TestAbandonedBasicDataSource.testAbandonedCloseWithExceptions(TestAbandonedBasicDataSource.java:101) ========================== %< ================================ I do not see those using IBM-JDK 1.5.0.10. With this I had a casually 1 failure, but no test reports are generated with Ant nor could I see on the console which test actually failed. Additionally the Ant build filters-out the JDBC4 stuff ?!? I thought it's not there in 1.3. > 1.4 (JDBC 4) version: > http://people.apache.org/~psteitz/dbcp-1.4-rc1 > http://people.apache.org/~psteitz/dbcp-1.4-rc1/site > http://people.apache.org/~psteitz/dbcp-1.4-rc1/maven > http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC1/ Builds from source and runs tests with IcedTea6 1.6.2, Sun JDK 1.6 and Sun JDK 1.7.0.0.alpha69 (add to README.txt ?!?). However it fails with IBM 1.6.0.6: ========================== %< ================================ ------------------------------------------------------------------------------- Test set: org.apache.commons.dbcp.managed.TestBasicManagedDataSource ------------------------------------------------------------------------------- Tests run: 46, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.398 sec <<< FAILURE! testReallyClose(org.apache.commons.dbcp.managed.TestBasicManagedDataSource) Time elapsed: 0.066 sec <<< FAILURE! junit.framework.AssertionFailedError: Expecting SQLException - XAResources orphaned at junit.framework.Assert.fail(Assert.java:47) at org.apache.commons.dbcp.managed.TestBasicManagedDataSource.testReallyClose(TestBasicManagedDataSource.java:72) ========================== %< ================================ > Release notes (common version, ships with both) > http://people.apache.org/~psteitz/RELEASE-NOTES.txt > > There is also a recently opened documentation bug (DBCP-309) that I > do not see as a showstopper for this release, but would appreciate > feedback on the ticket and concurrence that we can push it to > 1.3.1/1.4.1. The build setup itself looks good though, except a minor nit: ========================== %< ================================ [WARNING] While downloading xml-apis:xml-apis:2.0.2 This artifact has been relocated to xml-apis:xml-apis:1.0.b2. ========================== %< ================================ xml-apis-2.0.2 is simply a "wrong" release and we should refer the correct one. Cheers, Jörg --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
