+0

The test coverage of Pack200CompressorInputStream is a bit low, the read methods do not seem to be tested.

Also in the matches() method the constant '4' could be replaced by CAFE_DOOD.length

Emmanuel Bourg


Le 26/10/2011 06:54, Stefan Bodewig a écrit :
Compress 1.3 RC1 is available for review here:
     http://people.apache.org/~bodewig/commons-compress/

   Maven artifacts are here:
     
https://repository.apache.org/content/repositories/orgapachecommons-101/org/apache/commons/commons-compress/1.3/

   Details of changes since 1.1 are in the release notes:
     http://people.apache.org/~bodewig/commons-compress/RELEASE-NOTES.txt
     http://people.apache.org/~bodewig/commons-compress/site/changes-report.html

   I have tested this with Sun JDK 1.5 and OpenJDK 1.6 using maven2.

   The tag is here (revision 1189016):
     http://svn.apache.org/viewvc/commons/proper/compress/tags/COMPRESS_1.3_RC1/

   Site:
     http://people.apache.org/~bodewig/commons-compress/site/

   Clirr Report (compared to 1.2):
     http://people.apache.org/~bodewig/commons-compress/site/clirr-report.html

   RAT Report:
     http://people.apache.org/~bodewig/commons-compress/site/rat-report.html

   Votes, please.  This vote will close in 72 hours, 0500 GMT 29-October 2011

   [ ] +1 Release these artifacts
   [ ] +0 OK, but...
   [ ] -0 OK, but really should fix...
   [ ] -1 I oppose this release because...


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to