Hi again Torsten! I thought it would be useful having a checkstyle also becasue it is not just a matter of code formatting rules, there are also useful basic checks <http://checkstyle.sourceforge.net/checks.html> that help - me, at least - on taking care of some rules I can occasionally forget to apply.
> And I say - better let's give people the tools and not just point at them. I agree. IIUC the proposal of putting checkstyle in the parent came out because it is plugged in every plugin, so the purpose is more generalize rather then point to it. All the best! -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Tue, Mar 13, 2012 at 2:27 PM, Torsten Curdt <tcu...@vafer.org> wrote: >> CheckStyle reports should be checked regularly. Only doing so just before a >> release indeed leads to a lot of tedious work, because coders did not >> respect the basic, agreed on, style. > > I guess we are disagreeing here. > >> I don't use an IDE, so for me, CheckStyle helps but formatter IDE plugins >> would not. Our mileage do vary but the end-product (clean code) should not. > > Then you are probably a vocal minority here. > As long as there is someone that can run a code formatter before a > release that does not matter though. > >> As said in another post, you can always disable reports that you find >> unhelpful. > > Fair enough. But projects that find it useful could also just add the report > :) > We are discussing about what should be the default here. > That said I rather just disable it in the POM that continue with the > discussion. > >>> The basic code style is like logging - people spent just wait too much >>> time on this. > > ...because I dont' want to contribute to that time any more. > >> The real problem is that some coders do not do their part of the job when >> they commit badly formatted code. >> Those whose spend too much time are the ones who try to clean up the mess >> afterwards. > > If you prefer to not use code formatter - that is. But that's your decision. > > Menu > "Format Source Code" > Done. > > ...plus I am bet there are ways to set up code formatting for vim and > friends - if one wanted to. > >> CheckStyle indeed points a finger to the right person, which IMHO helps by >> making this person aware that he should fix it. > > And I say - better let's give people the tools and not just point at them. > > cheers, > Torsten > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
