Hi Paul, many thanks for your feedback.
Am 10.11.2013 04:28, schrieb Paul Benedict: > Some feedback: > > 1) Classes with HTML formatting problems that are messing up the javadocs. > They are likely all due to missing end tags: > * MappedPropertyDescriptor > * LazyDynaMap > * LazyDyanClass > * LazyDynaBean > * ConvertUtilsBean > * BeanPropertyValueEqualsPredicate > * BasicDynaBean Fixed. Thanks for spotting this. > > 2) Does Converter have a contract to convert multiple type Ts or just one > type T? Type T is in the method signature only but if the implementation is > only supposed to convert one type, it should become a class type. Indeed, converters can support multiple types. A typical converter implements a conversion to a specific target type and a conversion to string. (To be honest, I do not like this design very much, but now it is too late to change.) > > 3) I am not a fan of <B> in BeanComparator. It makes me think too hard. I > prefer <T>. Okay, changed in SVN. I wanted to be too clever ;-) > > Paul > > > > On Sat, Nov 9, 2013 at 2:16 PM, Oliver Heger > <oliver.he...@oliver-heger.de>wrote: > >> Hi Paul, >> >> Am 09.11.2013 19:31, schrieb Paul Benedict: >>> Oliver, would you have time to publish a snapshot of 1.9's site so I can >>> browse the javadocs and source xref? I can easily provide feedback if you >>> do that. >> >> thanks for your interest! I uploaded the site to [1]. All comments are >> welcome! >> >> Oliver >> >> [1] http://people.apache.org/~oheger/beanutils-site/index.html >> >>> >>> >>> On Sat, Nov 9, 2013 at 12:07 PM, Oliver Heger >>> <oliver.he...@oliver-heger.de>wrote: >>> >>>> Just a heads-up that I intend to start the preparations for a >>>> [beanutils] 1.9.0 release soon. So if there is something you want to see >>>> included in this release, now is a good time to step up. >>>> >>>> It would be great if somebody could find the time to review the changes >>>> made for adding generics [1]. >>>> >>>> TIA >>>> Oliver >>>> >>>> [1] https://issues.apache.org/jira/browse/BEANUTILS-452 >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>>> >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
