On 2013-12-20, sebb wrote:

> On 20 December 2013 17:07, Stefan Bodewig <bode...@apache.org> wrote:
>> On 2013-12-20, Gary Gregory wrote:

>>> We get PMD warnings in
>>> org.apache.commons.compress.archivers.jar.JarArchiveEntry about methods
>>> only calling super.

>>> Either document that the methods are placeholders for future
>>> implementations (TODO) or remove the methods.

>> Actually it is neither.  If you remove the methods findbugs will
>> complain that JarEntry doesn't override equals() - it's a choice between
>> Findbugs or PMD being unhappy.

> Are you sure?

Yes, I actually tried it again before sending my email.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to