Thank you for the fixes Benedikt. Le 15/07/2014 20:07, Benedikt Ritter a écrit :
> skipHeaderRecord refers to the header records as a whole (so it's > singular). ignore empty headers refers to header column values, so it's > plural. I guess that makes sense. Ok, I misunderstood the intent then. Here "header" refers to a column name, not the header record. What about renaming the property to something like with/isUndefinedColumnIgnored() or with/isEmptyColumnAllowed() to avoid the confusion? > I've changed all methods to "is * ing". Now only isCommentingEnabled is > left. I don't know what to do with this. I'm still looking forward to > comments from a native speaker :) I tend to prefer withSurroundingSpacesIgnored over withIgnoringSurroundingSpaces. Native speakers advices are welcome. > I've tried to clarify the JavaDoc of the said methods. Can you please > review? It looks good, thank you. > No it doesn't. How about adding this in 1.1? I've created CSV-123 for this. Ok, but we should document if the current method prints the header or not. Emmanuel Bourg --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
