Just to make it clear... We're happy with: - boolean isIgnoringSurroundingSpaces() - withIgnoreSurroundingSpaces(boolean)
So nothing has to change? Benedikt Send from my mobile device > Am 18.07.2014 um 16:12 schrieb Gary Gregory <[email protected]>: > > There is a nice pattern now with ivar and method names where we have the > ivar ignoreSomething (note that it is verb first in the active void) and > withIgnoreSomething. > > It is important IMO to use the active void instead of passive > (somethingIgnored) to make it clear who performs the action. > > It's withIgnoreSurroundingSpaces, not withIgnoringSurroundingSpaces() BTW. > > So I do not think there is anything wrong with this one. > > Gary > > >> On Fri, Jul 18, 2014 at 7:54 AM, Emmanuel Bourg <[email protected]> wrote: >> >> Thank you for the fixes Benedikt. >> >> Le 15/07/2014 20:07, Benedikt Ritter a écrit : >> >>> skipHeaderRecord refers to the header records as a whole (so it's >>> singular). ignore empty headers refers to header column values, so it's >>> plural. I guess that makes sense. >> >> Ok, I misunderstood the intent then. Here "header" refers to a column >> name, not the header record. What about renaming the property to >> something like with/isUndefinedColumnIgnored() or >> with/isEmptyColumnAllowed() to avoid the confusion? >> >> >>> I've changed all methods to "is * ing". Now only isCommentingEnabled is >>> left. I don't know what to do with this. I'm still looking forward to >>> comments from a native speaker :) >> >> I tend to prefer withSurroundingSpacesIgnored over >> withIgnoringSurroundingSpaces. Native speakers advices are welcome. >> >> >>> I've tried to clarify the JavaDoc of the said methods. Can you please >>> review? >> >> It looks good, thank you. >> >> >>> No it doesn't. How about adding this in 1.1? I've created CSV-123 for >> this. >> >> Ok, but we should document if the current method prints the header or not. >> >> Emmanuel Bourg >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
