On Mon, Dec 29, 2014 at 10:04 AM, sebb <seb...@gmail.com> wrote: > On 29 December 2014 at 13:52, Gary Gregory <garydgreg...@gmail.com> wrote: > > On Mon, Dec 29, 2014 at 8:02 AM, Jörg Schaible <joerg.schai...@gmx.de> > > wrote: > > > >> Benedikt Ritter wrote: > >> > >> > Hello, > >> > > >> > We have received some requests to release the fixes we habe > implemented > >> in > >> > Commons Validator since 1.4 was released, so I would like to release > >> > Validator 1.4.1. Validator 1.4.1 RC1 is available for review here: > >> > https://dist.apache.org/repos/dist/dev/commons/validator/ (svn > revision > >> > 7587) Maven artifacts are here: > >> > > >> > >> > https://repository.apache.org/content/repositories/orgapachecommons-1071/commons-validator/commons-validator/1.4.1/ > >> > Details of changes since 1.4 are in the release notes: > >> > > >> > https://dist.apache.org/repos/dist/dev/commons/validator/RELEASE-NOTES.txt > >> > I have tested this with JDK 1.6, 1.7, 1.8 and 1.9 EA using maven > 3.2.5. > >> > Note that the build doesn't work with JDK 1.9 EA, since source and > target > >> > option 1.4 have been removed in JDK 1.9. The tag is here: > >> > > >> > >> > http://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_4_1_RC1/ > >> > (svn revision 1647978) Site: no site - I'm currently having trouble to > >> > login to people.apache.org, so I was unable to upload the site. > Please > >> > build the site yourself using mvn clean site. Clirr Report (compared > to > >> > 1.1): see above RAT Report: see above KEYS: > >> > https://www.apache.org/dist/commons/KEYS Please review the release > >> > candidate and vote. This vote will close no sooner that 72 hours from > >> now, > >> > i.e. after 2014/12/29 16:00 CET [ ] +1 Release these artifacts [ ] +0 > OK, > >> > but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this > release > >> > because... Thanks! Benedikt > >> > >> -1 > >> > > > > The simplest solution would be to up the platform requirement to Java 5, > > right? > > Not simple, because all the generics ought to be added. > This is not always an easy task. > > > The next question would be whether the release should still be > > labeled 1.4.1 instead of 1.5. > > Probably not, assuming that generics have been added. >
I tried 1.5 in Eclipse and there are generics warning but nothing seems too bad, the usual set of collection warnings at first glance at least. Gary > > > Gary > > > > > >> > >> The release claims to be Java 1.4 compatible, but you cannot build it > for > >> that JDK, because of commons-beanutils-1.9.x: > >> > >> =================== %< ====================== > >> $ mvn-3.0 clean package -P java-1.4 > >> [INFO] Scanning for projects... > >> [... snip ...] > >> [INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ > commons- > >> validator --- > >> [INFO] Changes detected - recompiling the module! > >> [INFO] Compiling 59 source files to /home/joehni/tmp/download/commons- > >> validator-1.4.1-src/target/classes > >> [INFO] ------------------------------------------------------------- > >> [ERROR] COMPILATION ERROR : > >> [INFO] ------------------------------------------------------------- > >> [ERROR] /home/joehni/tmp/download/commons-validator-1.4.1- > >> src/src/main/java/org/apache/commons/validator/Field.java:[31,-1] cannot > >> access org.apache.commons.beanutils.PropertyUtils > >> bad class file: /home/joehni/.m2/repository/commons-beanutils/commons- > >> beanutils/1.9.2/commons- > >> beanutils-1.9.2.jar(org/apache/commons/beanutils/PropertyUtils.class) > >> class file has wrong version 49.0, should be 48.0 > >> [INFO] 1 error > >> [INFO] ------------------------------------------------------------- > >> [INFO] > >> ------------------------------------------------------------------------ > >> [INFO] BUILD FAILURE > >> [INFO] > >> ------------------------------------------------------------------------ > >> [INFO] Total time: 7.972s > >> [INFO] Finished at: Mon Dec 29 13:54:00 CET 2014 > >> [INFO] Final Memory: 17M/35M > >> [INFO] > >> ------------------------------------------------------------------------ > >> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler- > >> plugin:3.2:compile (default-compile) on project commons-validator: > >> Compilation failure > >> [ERROR] /home/joehni/tmp/download/commons-validator-1.4.1- > >> src/src/main/java/org/apache/commons/validator/Field.java:[31,-1] cannot > >> access org.apache.commons.beanutils.PropertyUtils > >> [ERROR] bad class file: /home/joehni/.m2/repository/commons- > >> beanutils/commons-beanutils/1.9.2/commons- > >> beanutils-1.9.2.jar(org/apache/commons/beanutils/PropertyUtils.class) > >> [ERROR] class file has wrong version 49.0, should be 48.0 > >> [ERROR] -> [Help 1] > >> [ERROR] > >> [ERROR] To see the full stack trace of the errors, re-run Maven with > the -e > >> switch. > >> [ERROR] Re-run Maven using the -X switch to enable full debug logging. > >> [ERROR] > >> [ERROR] For more information about the errors and possible solutions, > >> please > >> read the following articles: > >> [ERROR] [Help 1] > >> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException > >> =================== %< ====================== > >> > >> Even when you downgrade beanutils to 1.8.4, you cannot compile the > tests: > >> > >> =================== %< ====================== > >> [INFO] ------------------------------------------------------------- > >> [ERROR] COMPILATION ERROR : > >> [INFO] ------------------------------------------------------------- > >> [ERROR] /home/joehni/tmp/download/commons-validator-1.4.1- > >> > >> > src/src/test/java/org/apache/commons/validator/routines/checkdigit/IBANCheckDigitTest.java: > >> [186,64] replace(char,char) in java.lang.String cannot be applied to > >> (java.lang.String,java.lang.String) > >> [INFO] 1 error > >> =================== %< ====================== > >> > >> - Jörg > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> > > > > > > -- > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > > Java Persistence with Hibernate, Second Edition > > <http://www.manning.com/bauer3/> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > > Spring Batch in Action <http://www.manning.com/templier/> > > Blog: http://garygregory.wordpress.com > > Home: http://garygregory.com/ > > Tweet! http://twitter.com/GaryGregory > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
