After an intense few minutes discussing the color of the bike shed with myself (package name) I moved the zip-unspecific parallel stuff to org.apache.commons.compress.parallel in r1654572. This concludes the changes Emmanuel suggested. I have already responded to a few of the comments that did not lead to code change; if anyone wants to discuss these matters further now would be a good time :)
I also further refined some javadocs a bit; I'll be reading through the full site for the new stuff once more tonight. I suppose the "what's new section" on the site also needs to be updated to 1.10 ? Anything else I can assist with before the release ? Kristian 2015-01-24 13:18 GMT+01:00 Stefan Bodewig <bode...@apache.org>: > On 2015-01-23, Emmanuel Bourg wrote: > >> Le 22/01/2015 17:30, Stefan Bodewig a écrit : > >>> Please have a look and identify stuff that looks as if I'd have to >>> reroll a new RC should it come to a vote with the current code base. > >> I reviewed the API changes, here are my comments: > >> - PasswordRequiredException: the exception is in the sevenz package, do >> we want to move it elsewhere so it can be used later for other formats >> like zip (if that makes sense). > > Moved to a new exceptions package. > >> - BitInputStream: why not using a long cache instead of an int, like >> BitStream before the refactoring? It might be interesting to do some >> benchmarks and see if it make a difference. > > We never needed more than 31 bits, but you are right, I'll try to > experiment a little. > > Stefan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
