On 1/25/16 1:30 PM, Gary Gregory wrote: > On Mon, Jan 25, 2016 at 7:47 AM, Matt Benson <mben...@apache.org> wrote: >> On Sun, Jan 24, 2016 at 9:37 PM, Gary Gregory <garydgreg...@gmail.com> > wrote: >>> On Sun, Jan 24, 2016 at 7:36 PM, Gary Gregory <garydgreg...@gmail.com> >>> wrote: >>> >>>> Antlib's Clirr report has a lot of errors: >>>> > https://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/clirr-report.html >>>> This is not documented in the release notes. >>>> >>> I am not -1'ing this but it needs an explanation. >> Thanks for catching this. However, I am at a loss except to say that, >> largely, these results are incorrect. The various classes belonging to >> the org.apache.tools.* namespace are Ant classes that were >> accidentally shaded in with the 1.1 release (Ant artifacts had to be >> promoted to compile scope so that clirr could even run), so their >> removal was deliberate--I'm sure I don't need to explain why our >> Antlib shouldn't bundle Ant's own classes. Several more claimed >> removals are of classes that were shaded in from commons-lang3 and >> Geronimo's xbean-finder libraries. I expect that these are incorrect >> anyway, but as they don't truly constitute part of the public API of >> the Antlib I would argue that they are immaterial here as long as the >> integration tests succeed, which they do. The remaining claimed >> removals are of classes shaded from the commons-weaver-processor >> artifact; I have verified that all the classes named remain in the jar >> so I have no idea why the report would generate false positives. >> >> With that information in hand, where do you now stand on this, Gary? > This needs to be explained clearly in the release notes. Like Sebb said, > there might be other places to document this as well.
I don't see the site bundled with the release, unless I am missing it somewhere. We release software, not websites. I see no reason to clutter the release notes about false positives in maven reports not included with the release. I would say fix whatever it is before republishing the site and move on. Phil > > Gary > >> >> Matt >> >>> Gary >>> >>> >>>> Gary >>>> >>>> On Thu, Jan 21, 2016 at 10:39 AM, Matt Benson <mben...@apache.org> > wrote: >>>>> I would like to release the [weaver] component. >>>>> >>>>> Apache Commons Weaver 1.2 RC2 is available for review at: >>>>> https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11994). >>>>> >>>>> Maven artifacts are at: >>>>> >>>>> > https://repository.apache.org/content/repositories/orgapachecommons-1141 >>>>> . >>>>> >>>>> Tested with Oracle JDKs 6, 7 and 8; IBM JDKs 6 and 7. >>>>> >>>>> The Subversion tag is: >>>>> http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/ >>>>> (r1726007 >>>>> < > http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.2_RC2/(r1726007 >>>>> ). >>>>> >>>>> Site (note some links may be broken; this will be fixed when the site >>>>> is deployed): >>>>> http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/index.html >>>>> >>>>> RAT Report: >>>>> >>>>> > http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/rat-report.html >>>>> Quality Reports (CLIRR/PMD/Checkstyle/Findbugs): >>>>> >>>>> > http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-processor/project-reports.html >>>>> > http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer-api/project-reports.html >>>>> > http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/commons-weaver-privilizer/project-reports.html >>>>> > http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-normalizer/project-reports.html >>>>> > http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-maven-plugin/project-reports.html >>>>> > http://people.apache.org/~mbenson/commons-weaver-1.2-rc2/commons-weaver-parent/commons-weaver-antlib/project-reports.html >>>>> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS >>>>> >>>>> Please review the release candidate and vote. >>>>> This vote will close no sooner than 72 hours from now, i.e. after >>>>> 1900UTC 24-January 2016 >>>>> >>>>> [ ] +1 Release these artifacts >>>>> [ ] +0 OK, but... >>>>> [ ] -0 OK, but really should fix... >>>>> [ ] -1 I oppose this release because... >>>>> >>>>> Thanks! >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>> >>>>> >>>> >>>> -- >>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >>>> Java Persistence with Hibernate, Second Edition >>>> <http://www.manning.com/bauer3/> >>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>>> Spring Batch in Action <http://www.manning.com/templier/> >>>> Blog: http://garygregory.wordpress.com >>>> Home: http://garygregory.com/ >>>> Tweet! http://twitter.com/GaryGregory >>>> >>> >>> >>> -- >>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >>> Java Persistence with Hibernate, Second Edition >>> <http://www.manning.com/bauer3/> >>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>> Spring Batch in Action <http://www.manning.com/templier/> >>> Blog: http://garygregory.wordpress.com >>> Home: http://garygregory.com/ >>> Tweet! http://twitter.com/GaryGregory >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
