On 16 May 2016 at 10:05, sebb <seb...@gmail.com> wrote: > On 16 May 2016 at 08:51, Stian Soiland-Reyes <st...@apache.org> wrote: >> In Jackrabbit's source code I find JcrUtils added in 2009: >> >> https://github.com/apache/jackrabbit/commit/0882a5cc1ed4ce1cf9d3c6b3a592f97c5772ce25 >> >> but Jackrabbit graduated from the incubator in 2006: >> >> http://incubator.apache.org/projects/jackrabbit.html >> >> >> So presumably the software from Day Software was added before that? > > Yes. > >> Which to me says this is a pure Apache contribution which is only >> covered by the regular "This product includes software developed at >> ASF" line. > > That depends on which source files were used. > Were they ones which came from Day originally? > Or new ones?
Ignore that, I see you found the actual source file, so clearly it is not from the original Day contribution. I was mislead by the comments in the source which implied it came from various sources. It would be helpful to identify the actual sources in the JIRA and VFS once they have been established (not a blocker IMO) >> I'll ask on dev@jackrabbit to be sure. >> >> >> Here's a suggested NOTICE line, in case we still need it: >> >> ------------------------------ >> commons-vfs2-project/core/src/test/java/org/apache/commons/vfs2/provider/webdav/test/JcrUtils.java >> Adapted from Apache Jackrabbit 2.4.0: >> >> Based on source code originally developed by >> Day Software (http://www.day.com/). >> ------------------------------ > > The NOTICE file is only for *required* attributions. > We should not add any text 'just in case' > > In any case, I'm not sure that the JackRabbit NOTICE file needs to > contain the "Based on ..." paragraph. > Is that para actually *required*? > >> >> We don't need to replicate the ASF self-attribution - see >> http://www.apache.org/dev/licensing-howto.html#bundle-asf-product >> >> >> ~ >> >> On 13 May 2016 at 17:48, Gary Gregory <garydgreg...@gmail.com> wrote: >>> On Fri, May 13, 2016 at 3:13 AM, sebb <seb...@gmail.com> wrote: >>> >>>> On 13 May 2016 at 01:24, Sean Busbey <bus...@apache.org> wrote: >>>> > -1 (non-binding) >>>> > >>>> > bad: >>>> > >>>> > * LICENSE/NOTICE file is missing a bundled third party reference[1] >>>> > >>>> > maybe fine: >>>> > >>>> > * source artifacts mostly match source tag[2] >>>> > * build / test from source works[3] >>>> > >>>> > fine: >>>> > * verified signatures and checksums[4] >>>> > >>>> > [1]: >>>> > >>>> > >>>> core/src/test/java/org/apache/commons/vfs2/provider/webdav/test/JcrUtils.java >>>> > >>>> > says it is copied from Apache Jackrabbit 2.4.0, which has a NOTICE.txt >>>> file. >>>> >>>> i.e. >>>> >>>> http://svn.apache.org/repos/asf/jackrabbit/tags/2.4.0/NOTICE.txt >>>> >>>> > there is no mention of this in the source repo NOTICE (I would presume >>>> the >>>> > related test jar would also be wrong). >>>> >>>> Whether that is needed or not depends on whether the specific file was >>>> part of the original source code from Day. >>>> >>>> The file was added as a part of fixing VFS-392 >>>> >>>> @Gary: can you advise which source files you used to create JcrUtils? >>>> >>> >>> No idea, that was a long time ago. All I can say for sure is that I was >>> looking at the Jackrabbit 1.6.5 or earlier sources. >>> >>> Gary >>> >>>> >>>> > [2]: >>>> > >>>> > The source tag contains an additional module 'sandbox' that is not in >>>> the source artifact. >>>> > >>>> > I am not sure if this is intentional, but it looks like it is. >>>> > >>>> > [3]: >>>> > >>>> > Related to [2], if you run `mvn verify` things are fine, but if you use >>>> the sandbox profile, >>>> > via `mvn -Pinclude-sandbox verify`, things fall over because the above >>>> mentioned module >>>> > is missing. >>>> > >>>> > [4]: >>>> > >>>> > everything properly checks out, but the format of the md5 file was >>>> different for the artifacts in >>>> > dist.apache compared to repository.apache. >>>> > >>>> > On 2016-05-11 20:29, Josh Elser <els...@apache.org> wrote: >>>> >> All, >>>> >> >>>> >> Please consider the following for Apache Commons VFS2 version 2.1 (rc2). >>>> >> >>>> >> Maven repository: >>>> >> >>>> https://repository.apache.org/content/repositories/orgapachecommons-1166 >>>> >> Artifacts: https://dist.apache.org/repos/dist/dev/commons/vfs/ r13608 >>>> >> >>>> >> MD5 commons-vfs-distribution-2.1-bin.tar.gz >>>> >> 8cc35a3169e1faee727c5af94c7dd904 >>>> >> SHA1 commons-vfs-distribution-2.1-bin.tar.gz >>>> >> 72b7557c4e8b1789b8aa0a9c1e0cb2c9daecec30 >>>> >> MD5 commons-vfs-distribution-2.1-src.tar.gz >>>> >> a182ac642874e85fbc7d1086f7663482 >>>> >> SHA1 commons-vfs-distribution-2.1-src.tar.gz >>>> >> e42ac2053deb314277213e43f6f1d6b43eff3de9 >>>> >> >>>> >> MD5 commons-vfs-distribution-2.1-bin.zip >>>> b512a45c63d824eef826f174fd7a9245 >>>> >> SHA1 commons-vfs-distribution-2.1-bin.zip >>>> >> 886cb5a430da58b3a68e2abf297b6f735d3ffaf0 >>>> >> MD5 commons-vfs-distribution-2.1-src.zip >>>> 29645a0ad091c15b2cf76b619c33069f >>>> >> SHA1 commons-vfs-distribution-2.1-src.zip >>>> >> 5824cf4d802865b5e93ff62c90affa58df6c4384 >>>> >> >>>> >> Signed with 4677D66C from >>>> >> https://dist.apache.org/repos/dist/release/commons/KEYS >>>> >> >>>> >> SVN tag is available at >>>> >> >>>> https://svn.apache.org/repos/asf/commons/proper/vfs/tags/commons-vfs2-project-2.1-rc2/ >>>> >> r1743451 >>>> >> >>>> >> Staged Maven website: >>>> >> http://home.apache.org/~elserj/commons/commons-vfs-2.1/ >>>> >> >>>> >> All reports are available in the provided staged Maven site (see >>>> "Project >>>> >> Reports" at the root-level as well as under each sub-module). >>>> JIRA-generated >>>> >> release notes are available in the dist.a.o "Artifacts" repository. Unit >>>> >> tests pass and the RC was built util JDK6. >>>> >> >>>> >> (For Sebb) A direct Clirr link >>>> >> >>>> http://home.apache.org/~elserj/commons/commons-vfs-2.1/commons-vfs2/clirr-report.html >>>> >> >>>> >> Changes since rc1: >>>> >> >>>> >> * Fixed more compatibility concerns against 2.0 (thanks, Greg) >>>> >> * Improved release notes (thanks, Sebb) >>>> >> >>>> >> This vote will be open for 72-hours, 2016/05/14 0400 UTC. >>>> >> >>>> >> [ ] +1 Release these artifacts as version 2.1 >>>> >> [ ] 0 OK, but... >>>> >> [ ] -1 I oppose these artifacts as version 2.1 because.. >>>> >> >>>> >> - Josh >>>> >> >>>> >> --------------------------------------------------------------------- >>>> >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> >> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >> >>>> >> >>>> > >>>> > --------------------------------------------------------------------- >>>> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> > For additional commands, e-mail: dev-h...@commons.apache.org >>>> > >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>>> >>> >>> >>> -- >>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >>> Java Persistence with Hibernate, Second Edition >>> <http://www.manning.com/bauer3/> >>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>> Spring Batch in Action <http://www.manning.com/templier/> >>> Blog: http://garygregory.wordpress.com >>> Home: http://garygregory.com/ >>> Tweet! http://twitter.com/GaryGregory >> >> >> >> -- >> Stian Soiland-Reyes >> Apache Taverna (incubating), Apache Commons RDF (incubating) >> http://orcid.org/0000-0001-9842-9718 >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
