Why not make the component require Java 7 and be done with it? Gary
On Wed, Oct 26, 2016 at 12:46 PM, Romain Manni-Bucau <rmannibu...@gmail.com> wrote: > 2016-10-26 21:35 GMT+02:00 Benedikt Ritter <brit...@apache.org>: > > > Hello Thomas, > > > > Thomas Vandahl <t...@apache.org> schrieb am Fr., 21. Okt. 2016 um 19:42 > Uhr: > > > > > I would like to beta-release the [jcs] component. > > > > > > Apache Commons JCS 2.0-beta-2 RC1 is available for review at: > > > https://dist.apache.org/repos/dist/dev/commons/jcs/ (r16621). > > > > > > Maven artifacts are at: > > > https://repository.apache.org/content/repositories/ > > orgapachecommons-1211 > > > . > > > > > > The Subversion tag is: > > > > > > > > > https://svn.apache.org/repos/asf/commons/proper/jcs/tags/ > > commons-jcs-2.0-beta-2 > > > (r1766068). > > > > > > The release notes are at: > > > > > > > > > https://svn.apache.org/repos/asf/commons/proper/jcs/tags/ > > commons-jcs-2.0-beta-2/RELEASE-NOTES.txt > > > (r1766068). > > > > > > Please review the release candidate and vote. > > > > > > [ ] +1 Release these artifacts > > > [ ] +0 OK, but... > > > [ ] -0 OK, but really should fix... > > > [ ] -1 I oppose this release because... > > > > > > Please be lenient with me as this is my first Commons release attempt. > > > > > > > Thank you for preparing your first RC for commons. Here is my assessment: > > > > - signs and hashes look good > > - builds from sources Java 7 + Java 8 on Maven 3.3.9 on Mac OS 10.11.6 > > - build fails with Java 6 with Maven 3.2.5, here is the build log [1]. It > > looks like the tomcat dependency used in the extras module requires Java > 7. > > > > Yes Tomcat requires Java 7 - as well as jcache strictly speaking. > > Doesn't look like a blocker since the build already requires to build with > java >= 7. > > > > - Where is the RC website? > > - release notes looks good (although release notes don't need a license > > header) > > - the maven repository contains the src and binary archives. We usually > > remove them from the staging area before closing the staging repo. Not a > > problem for me. > > > > I have discovered one problem. The release tag and the source archive > have > > differing contents: > > > > > diff -wqr commons-jcs-dist-2.0-beta-2 TAG > > Only in TAG: .gitignore > > Only in TAG: .svn > > Only in commons-jcs-dist-2.0-beta-2/: LICENSE > > Only in TAG: LICENSE.txt > > Only in commons-jcs-dist-2.0-beta-2/: NOTICE > > Only in TAG: NOTICE.txt > > Only in TAG: auxiliary-builds > > Only in TAG: checkstyle.xml > > Only in commons-jcs-dist-2.0-beta-2/commons-jcs-jcache-extras: tomcat.0 > > Only in commons-jcs-dist-2.0-beta-2/commons-jcs-jcache-openjpa: > derby.log > > Only in TAG: commons-jcs-sandbox > > Only in TAG: init-git-svn.sh > > Only in TAG: jcache-fast.sh > > Only in TAG: maven-eclipse-codestyle.xml > > > > To me it looks like the assembly build is missing some entries for build > > files and shell scripts. Further more it seems like some temp files have > > been included in the source release: tomcat.0 and derby.log. I'm not sure > > about the NOTICE and LICENSE files. It looks like they have just been > > relocated in the source release. Nevertheless, I think the missing build > > files and the temp files need to be fixed in the source release. > > > > For this reason and the build failure on Java 6: > > > > -1 > > > > Please don't be discouraged by this. Remember that I had to create like > 20 > > RCs for BCEL 6.0. But in the end we managed to release that thing :-) > > > > Regards and thank you! > > Benedikt > > > > [1] https://paste.apache.org/41di > > > > > > > > > > Bye, Thomas > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459> JUnit in Action, Second Edition <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021> Spring Batch in Action <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
