> On Jan 14, 2018, at 6:50 PM, sebb <seb...@gmail.com> wrote: > >> On 13 January 2018 at 15:56, Rob Tompkins <chtom...@gmail.com> wrote: >> >> >>> On Jan 11, 2018, at 7:25 PM, sebb <seb...@gmail.com> wrote: >>> >>> On 11 January 2018 at 14:42, Rob Tompkins <chtom...@gmail.com> wrote: >>>> If you do try to run it locally make sure you add >>>> <dryRun>true</dryRun> >>> >>> It would be useful to be able to define this on the command-line. >> >> Bug found: >> >> https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionStagingMojo.java#L88 >> >> <https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionStagingMojo.java#L88> >> >> @Parameter(defaultValue = "false”) >> >> should be: >> >> @Parameter(property = "dryRun", defaultValue = "false”) > > Can that clash with other plugins that have a dry-run feature? > If so, maybe it needs a distinguishing prefix. >
+1, thoughts on a follow on release with that and then some support for [rng]. Fortunately, as it is you can define your own dryRun -D variable based on what I said just below. >> >> The intermediate workaround, like I emailed earlier, is: >> >> <dryRun>${dryRun}</dryRun> in the configuration section. >> >> -Rob >> >>> >>>> To the configuration section of the plugin. >>>> >>>>> On Jan 11, 2018, at 3:58 AM, Jörg Schaible >>>>> <joerg.schai...@bpm-inspire.com> wrote: >>>>> >>>>> Am Wed, 10 Jan 2018 20:35:52 -0700 schrieb Gary Gregory: >>>>> >>>>>> I wonder if: >>>>>> - This should be a LAZY VOTE since this is not an official component but >>>>>> rather a tool >>>>> >>>>> +1 >>>>> >>>>>> - We should release it as 1.0 anyway (unless obvious bugs >>>>>> are found) to avoid the chicken and egg problem: To really test this, I >>>>>> want to create an RC for Commons Collection (for example). But that >>>>>> means using a commons-release-plugin 1.0 version in my POM - which we >>>>>> cannot release as a repeatable build since 1.0 is not out yet. And >>>>>> cutting an RC with a 1.0-SNAPSHOT is not acceptable (not repeatable.) >>>>> >>>>> we might release 1.0-RC1 (or 0.1) as Sergio suggested. >>>>> >>>>> Cheers, >>>>> Jörg >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org