Curious if anyone else wants to weigh in? > On Jan 16, 2018, at 6:55 AM, Stian Soiland-Reyes <st...@apache.org> wrote: > > +1 (Binding) > > (While I might disagree in principle about removing source .tar.gz and > .zip from Maven repo, I say let's get the plugin released and find > more bugs later! :) ) >
This *should* be a configurable option. I don’t think though that it is in this version of the plugin. Personally, I want the plugin to accommodate any process that the project may use. So as the process changes one direction or another, so should the plugin. > Checked: > > +1 gpg signatures > +1 sha1, md5 > +1 source zip vs tar.gz > +1 binary zip vs tar.gz > +1 source vs git (for some reason git has duplicate LICENSE as well as > LICENSE.txt) > +1 mvn apache-rat:check > +1 no binaries (except test archives) > +1 LICENSE, NOTICE > +0 README refers to > https://commons.apache.org/proper/commons-commons-release-plugin/javadocs/api-release > which is 404 Not Found (site.zip has apidocs/) > +1 RELEASE-NOTES > +1 mvn clean install > +0 mvn repository kind of matches src? *) > > *) I was unable to verify that > https://repository.apache.org/content/repositories/orgapachecommons-1302 > contained artifacts from building this RC as the Maven repo do not > include the source zip/tar.gz (see principle above) > > > > > Tested with: > > Apache Maven 3.3.9 > Maven home: /usr/share/maven > Java version: 1.8.0_151, vendor: Oracle Corporation > Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre > Default locale: en_GB, platform encoding: UTF-8 > OS name: "linux", version: "4.13.0-26-generic", arch: "amd64", family: "unix" > >> On 11 January 2018 at 02:50, Rob Tompkins <chtom...@apache.org> wrote: >> Hello all, >> >> This is a [VOTE] for releasing Apache commons-release-plugin 1.0 (from RC1). >> >> Tag name: >> commons-release-plugin-1.0-RC1 (signature can be checked from git using >> 'git tag -v') >> >> Tag URL: >> >> https://git-wip-us.apache.org/repos/asf?p=commons-release-plugin.git;a=tag;h=6b05b8bee894ad471c5e1eda979550b344c21020 >> >> Commit ID the tag points at: >> 2f48a0ebd07318419b4d92a7e7b594f4fca47428 >> >> Site: >> >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/site.zip >> >> Distribution files (committed at revision 24125): >> https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/ >> >> Distribution files hashes (SHA1): >> commons-release-plugin-1.0-bin.tar.gz >> (SHA1: 02a0e034ed89c87e620ceaf4aef879121d4b87de) >> commons-release-plugin-1.0-bin.zip >> (SHA1: e0c4cf6449f6baab4c52c98c1e577512486d8fba) >> commons-release-plugin-1.0-src.tar.gz >> (SHA1: e48b67b70b154b7dc69914752814512225024504) >> commons-release-plugin-1.0-src.zip >> (SHA1: bc9a6c847899b2700e5873c4ac1a8d983476b255) >> >> These are the Maven artifacts and their hashes: >> commons-release-plugin-1.0-javadoc.jar >> (SHA1: bc2cdfa56f55ee538087038a1194ea2789863ca9) >> commons-release-plugin-1.0-sources.jar >> (SHA1: eb20eec8580fd5a2633bd2822e951d57043d3d4e) >> commons-release-plugin-1.0-test-sources.jar >> (SHA1: 61aa51b44025ced470b0e21b19a3eb65e154df1f) >> commons-release-plugin-1.0-tests.jar >> (SHA1: a81f42e01ca77a86048e07963d4ea496a69251f6) >> commons-release-plugin-1.0.jar >> (SHA1: 2897ab01d2e8460d100d196db55e53b2a1bab73e) >> commons-release-plugin-1.0.pom >> (SHA1: 2bcc663eb212f9a2233acc21773ef80883ac0881) >> >> KEYS file to check signatures: >> http://www.apache.org/dist/commons/KEYS >> >> Maven artifacts: >> https://repository.apache.org/content/repositories/orgapachecommons-1302 >> >> Please select one of the following options[1]: >> [ ] +1 Release it. >> [ ] +0 Go ahead; I don't care. >> [ ] -0 There are a few minor glitches: ... >> [ ] -1 No, do not release it because ... >> >> >> This vote will be open at least 72 hours, i.e. until >> 2018-01-14T03:00:00Z >> (this is UTC time). >> >> -------- >> >> Cheers, >> -Rob >> >> [1] http://apache.org/foundation/voting.html >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > > > -- > Stian Soiland-Reyes > http://orcid.org/0000-0001-9842-9718 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org