On Mon, Feb 12, 2018 at 12:30 PM, Pascal Schumacher < pascalschumac...@gmx.net> wrote:
> Am 12.02.2018 um 18:52 schrieb Gary Gregory: > >> I agree 100% and will proceed. I thought about it overnight and it does >> not >> make sense to leave a mix of abstract classes and interfaces in >> StrSubstitutor. >> > > +1, but > > please revert "Update actual Checkstyle from 6.19 to 8.8.", as Checkstyle > 7+ requries Java 8+. > Done. > > and please fix the findbugs violation: > > [INFO] --- findbugs-maven-plugin:3.0.5:check(default-cli)@ commons-text--- > [INFO] BugInstance size is 1 > [INFO] Error size is 0 > [INFO] Total bugs: 1 > [INFO] org.apache.commons.text.StringTokenizer.clone() does not call > super.clone() [org.apache.commons.text.StringTokenizer] At > StringTokenizer.java:[lines 1138-1140] CN_IDIOM_NO_SUPER_CALL > But super.clone() is called, from another method... Gary > > to fix the travis build. > > Thanks, > Pascal >
