On Tue, Feb 13, 2018 at 11:06 AM, Pascal Schumacher < pascalschumac...@gmx.net> wrote:
> Am 12.02.2018 um 21:53 schrieb Gary Gregory: > >> On Mon, Feb 12, 2018 at 12:53 PM, Gary Gregory <garydgreg...@gmail.com> >> wrote: >> >> On Mon, Feb 12, 2018 at 12:30 PM, Pascal Schumacher < >>> pascalschumac...@gmx.net> wrote: >>> >>> please revert "Update actual Checkstyle from 6.19 to 8.8.", as Checkstyle >>>> 7+ requries Java 8+. >>>> >>>> Done. >>> >> > Thanks! > >> and please fix the findbugs violation: >>>> >>>> [INFO] --- findbugs-maven-plugin:3.0.5:check(default-cli)@ >>>> commons-text--- >>>> [INFO] BugInstance size is 1 >>>> [INFO] Error size is 0 >>>> [INFO] Total bugs: 1 >>>> [INFO] org.apache.commons.text.StringTokenizer.clone() does not call >>>> super.clone() [org.apache.commons.text.StringTokenizer] At >>>> StringTokenizer.java:[lines 1138-1140] CN_IDIOM_NO_SUPER_CALL >>>> >>>> But super.clone() is called, from another method... >>> >>> And findbugs does not complain about the same code in StrTokenizer. What? >> > > For StrTokenizer there is an exclusion in fb-excludes.xml. Thank you for the pointer. I updated the FB exclusion file to do the same for org.apache.commons.text.StringTokenizer. Gary > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
