On Wed, May 9, 2018 at 9:28 AM, Rob Tompkins <chtom...@gmail.com> wrote:
> +1 > > Signatures Ok, > Rat OK > build ok maven 3.5.3: java7, java8, java9, > > > Some nits 1. is the main one that needs to be addressed: > > 1. RELEASE-NOTES.txt has "-SNAPSHOT" in it....fixable after the fact. > 2. dist artifact signatures have carrage return at end of hash (maybe bug > in release-plugin) > 3. Site is broken (clearly a release plugin windows bug) > I can unzip the site.zip and it seems OK. How is it broken for you? Gary > 4. Few findbugs issues. > 5. Low coverage (might try to convince some folks at my day job to help > with this) > > -Rob > > > On May 8, 2018, at 8:08 PM, Gary Gregory <ggreg...@apache.org> wrote: > > > > We have fixed quite a few bugs and added some significant enhancements > > since Apache Commons DBCP 2.2.0 was released, so I would like to release > > Commons DBCP 2.3.0. > > > > Commons DBCP 2.3.0 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/dbcp/ (svn revision > > 26776) > > > > The tag is here: > > > > https://git1-us-west.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h= > 830f0bf135ebc94cec7f2700171a2850430f76f7 > > > > Maven artifacts are here: > > > > https://repository.apache.org/content/repositories/ > orgapachecommons-1326/org/apache/commons/commons-dbcp2/2.3.0/ > > > > These are the Maven artifacts and their hashes > > > > /org/apache/commons/commons-dbcp2/2.3.0/commons-dbcp2-2.3.0.jar.asc > > (SHA1: 61a0593f9e79568a17cdf96a27f35a153661811e) > > /org/apache/commons/commons-dbcp2/2.3.0/commons-dbcp2-2.3.0.jar > > (SHA1: bbb2876368ecb71f0108af1e09ceeb17b8688176) > > /org/apache/commons/commons-dbcp2/2.3.0/commons-dbcp2-2.3. > 0-tests.jar.asc > > (SHA1: 9bd5ef92ff5716ca59afb64c0030d9cd1b08178b) > > /org/apache/commons/commons-dbcp2/2.3.0/commons-dbcp2-2.3.0-tests.jar > > (SHA1: 92fc4af0d3348c715bd4d78be4fd800a84eca604) > > /org/apache/commons/commons-dbcp2/2.3.0/commons-dbcp2-2.3.0.pom > > (SHA1: 8baf6f5f0083960ff08b91e173847bf7aaa6ac7c) > > /org/apache/commons/commons-dbcp2/2.3.0/commons-dbcp2-2.3. > 0-test-sources.jar > > (SHA1: 74bb2457d0b523a8dd7efc2538c705ece5ac53e8) > > /org/apache/commons/commons-dbcp2/2.3.0/commons-dbcp2-2.3. > 0-sources.jar.asc > > (SHA1: 6ccd175cbbbe583015db4ad3c62e9fed19b7135d) > > /org/apache/commons/commons-dbcp2/2.3.0/commons-dbcp2-2.3.0-sources.jar > > (SHA1: fbe38b9ccf3e85b7ea712e56b2d31d9bbc775074) > > /org/apache/commons/commons-dbcp2/2.3.0/commons-dbcp2-2.3. > 0-javadoc.jar.asc > > (SHA1: cc6606a256ec98028a8c357bab47dbacfdd154fe) > > /org/apache/commons/commons-dbcp2/2.3.0/commons-dbcp2-2.3. > 0-test-sources.jar.asc > > (SHA1: 5b42b57b996266d2b7804d457af094cd00a93a88) > > /org/apache/commons/commons-dbcp2/2.3.0/commons-dbcp2-2.3.0-javadoc.jar > > (SHA1: 0ea7fbe2914a272794befb9c98f831cc754b9e04) > > /org/apache/commons/commons-dbcp2/2.3.0/commons-dbcp2-2.3.0.pom.asc > > (SHA1: e962ee933cfeb18e1b061e3dce5e62487df958d1) > > > > I have tested this with: > > > > Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; > > 2018-02-24T12:49:05-07:00) > > Maven home: C:\Java\apache-maven-3.5.3\bin\.. > > Java version: 1.8.0_172, vendor: Oracle Corporation > > Java home: C:\Program Files\Java\jdk1.8.0_172\jre > > Default locale: en_US, platform encoding: Cp1252 > > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > > > Details of changes since 2.2.0 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt > > changes-report.html in > > https://dist.apache.org/repos/dist/dev/commons/dbcp/site.zip > > > > Site: > > https://dist.apache.org/repos/dist/dev/commons/dbcp/site.zip > > (note some *relative* links are broken and the 2.3.0 directories are > > not yet created - these will be OK once the site is deployed) > > > > The site contains a CLIRR report but not a JApiCmp report because I > could > > not get JApiCmp to work. > > > > Clirr Report (compared to 2.2.0): > > clirr-report.html in > > https://dist.apache.org/repos/dist/dev/commons/dbcp/site.zip > > > > RAT Report: > > rat-report.html in > > https://dist.apache.org/repos/dist/dev/commons/dbcp/site.zip > > > > KEYS: > > https://www.apache.org/dist/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner that 72 hours from now, > > i.e. sometime after 04:00 UTC 31-March 2010 > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thanks! > > > > Gary Gregory > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
