Github user kinow commented on a diff in the pull request:

    https://github.com/apache/commons-imaging/pull/35#discussion_r210521304
  
    --- Diff: 
src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java ---
    @@ -327,7 +331,7 @@ private BmpImageContents readImageContents(final 
InputStream is,
             switch (bhi.compression) {
             case BI_RGB:
                 if (verbose) {
    --- End diff --
    
    You are both correct @garydgregory , @sebbASF .
    
    I tried to remove the flags `DEBUG` or `isDebug()` or `getDebug()` by 
`LOGGER.isLoggable(Level.FINE)`, but forgot to do the same for `verbose` using 
the `INFO` level (wonder if we should use FINEST for debug, and FINE for the 
verbose messages...)
    Will just log to info. I believe we can assume that 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to