+1 We did the migration 4 -> 5 for various products at work. It was straightforward. I vote for a clean cut, as well. s/Before/BeforeEach/ s/After/AfterEach .... and you are halfway through. Sven Gesendet: Montag, 27. Mai 2019 um 07:28 Uhr Von: "Eitan Adler" <li...@eitanadler.com> An: "Heinrich Bohne" <heinrich.bo...@gmx.at> Cc: "Commons Developers List" <dev@commons.apache.org> Betreff: Re: Proposal to introduce JUnit 5 in commons-numbers (please make sure to CC me directly on replies)
On Sun, 26 May 2019 at 17:17, Heinrich Bohne <heinrich.bo...@gmx.at> wrote: > ... (I didn't subscribe to the list, which I now regret as I am editing > the header fields of this email manually, hoping that I do it correctly and > that the message will be attributed to the correct thread). > This is the first time I seeing this thread. > Regarding the point about a potential mess of multiple JUnit versions: > JUnit 5 seems to provide a "Vintage" test engine to support the execution > of JUnit 3 and 4 tests alongside JUnit 5 tests. > It is precisely this that I am advocating against. While JUnit 5 has a method of running older tests, by leaving the older style tests around we're producing confusion as to how it will get run or how to write new tests. Using it as a migration tool is reasonable, but the commons are small enough that wholesale migration is "easy". > > -- Eitan Adler --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
