On Tue, 4 Jun 2019 at 16:09, Heinrich Bohne <heinrich.bo...@gmx.at> wrote:
> So, if the migration from JUnit 4 to JUnit 5 has to happen > instantaneously, how about creating a new branch for the migration? It's > a lot of files that have to be refactored, which is going to take some > time, and since the changes will need to be reviewed, it would probably > be easier if the review can already take place while the migration is in > progress, rather than all at once when it is finished. Also, it would > reduce the risk of conflicting pull requests, thus potentially saving time. > I don't think it has to be done instantaneously but it shouldn't drag on, or be done "as we go". In terms of creating a branch: seems reasonable to me. I'll happily contribute and review. That said, the first change we need to make is to modify `pom.xml` to support running JUnit 5 tests + the vintage runner. I don't know maven too well but took a stab at it here: https://github.com/apache/commons-numbers/pull/47 -- Eitan Adler
