Hello. Le sam. 1 juin 2019 à 21:56, Karl Heinz Marbaise <khmarba...@gmx.de> a écrit : > > Hi, > I've created a branch[1] which fixes some checkstyle reported issues. > The resulting build[2] shows the issues have been fixed. > > Can someone take a look at that... > > If there are no objections would it be Ok to merge that to master?
I'm against "throws" clauses for unchecked exception; as per J. Bloch: "[...] do not provide throws clauses for unchecked exceptions".[1] Regards, Gilles [1] https://books.google.be/books?id=ka2VUBqHiWkC&pg=PA253&lpg=PA253&dq=effective+java+bloch+throws+clause+unchecked&source=bl&ots=y_HoMgr2Q0&sig=ACfU3U2ffB7Nq_sS4VAFz0vVACe8fPT8WA&hl=fr&sa=X&ved=2ahUKEwiM0q-QncniAhUIY1AKHZm0CY4Q6AEwDHoECAkQAQ#v=onepage&q=effective%20java%20bloch%20throws%20clause%20unchecked&f=false > > Kind regards > Karl Heinz Marbaise > > [1]: > https://gitbox.apache.org/repos/asf?p=commons-geometry.git;a=commitdiff;h=6bfaf0653730bc8edc701b4e34f24d04adbaa78a > [2]: https://travis-ci.org/apache/commons-geometry/builds/540087047 > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
