On 28/06/2019 15:49, Gary Gregory wrote: > +1 > > TODO later: Update RNs since the POM uses version "1.2.0" and the release > notes use "1.2".
That is by design. The release notes are intended for the entire 1.2.x release stream. This is how Daemon has done it in the past. Do we want to switch to point release specific notes, change the version in the release notes to 1.2.x or something else? > TODO later: src\native\windows\README should have a file extension since on > Windows text files without extensions are not customary. I'll get that done now and I'll check for any other extension-less files too. > TODO later: Fix Javadocs for Java 11 with 'mvn -V clean install site' > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on > project commons-daemon: Error generating maven-javadoc-plugin:3.1.0:javadoc > report: > [ERROR] Exit code: 1 - > C:\temp\rc\commons-daemon\src\main\java\org\apache\commons\daemon\DaemonPermission.java:38: > error: attribute not supported in HTML5: width > [ERROR] * <table width="100%" border="1"> Fixed (locally - I'll commit shortly). I was surprised that was the only issue. > Java 8 OK with: > - 'mvn apache-rat:check', > - 'mvn clirr:check'. > - 'mvn -V clean install site', > > Java 11 OK with 'mvn -V clean install' > > I was able to run 'nmake CPU=X86' (NMake Version 14.21.27702.2) on Windows > 10.0.16299.1087 for both Windows apps. There is no 'SetEnv' script in my VS > install so 'nmake CPU=X64' failed. Our README needs a bit of updating. More than a bit :) > Did you use the antique versions mentioned in the README? If not, please > update the file for future reference. I'll update the release build instructions. It should be possible to build with recent Visual Studio versions too. If someone familiar with that tool can add instructions for Visual Studio that would be helpful. > Java versions mentioned above: > > Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; > 2019-04-04T15:00:29-04:00) > Maven home: C:\Java\apache-maven-3.6.1\bin\.. > Java version: 11.0.3, vendor: Oracle Corporation, runtime: C:\Program > Files\Java\jdk-11.0.3 > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; > 2019-04-04T15:00:29-04:00) > Maven home: C:\Java\apache-maven-3.6.1\bin\.. > Java version: 1.8.0_212, vendor: Oracle Corporation, runtime: C:\Program > Files\Java\jdk1.8.0_212\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Gary Many thanks. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
