My vote: +1 (binding)
Verified:
+1 sha512 sha256
+1 asc / KEYS
+1 src zip vs tar.gz
+1 bin zip vs tar.gz vs jar
+1 src vs git (missing in src: README.md CONTRIBUTING.md;
whitespace differences in commons-daemon-1.2.0-native-src)
+1 mvn repo vs dist
+1 mvn apache-rat:check
+1 No unexpected binaries in src (bmp, rtf, ico)
+1 LICENSE NOTICE
+0 GPL code in src/native/unix/support/config.*
(permitted w/ autoconf exception)
+1 mvn clean install
-1 commons-daemon-1.2.0-native-src/unix/INSTALL.txt outdated
+1 ./configure ; make (tested just ./jsvc --help )
Tested with Ubuntu 18.04 TLS
$ mvn -v
Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
2018-10-24T19:41:47+01:00)
Maven home: /home/stain/software/maven
Java version: 11.0.3, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/java-11-openjdk-amd64
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-52-generic", arch: "amd64", family: "unix"
I did not test building or running the Windows part.
commons-daemon-1.2.0-native-src/unix is outdated as it claims you only
need to run "sh support/buildconf.sh" if building from SVN. We are using
git, and I still had to run it when building from dist/sources
On Fri, 28 Jun 2019 15:20:56 +0100, Mark Thomas <ma...@apache.org> wrote:
> It has been ~18 months since the last Commons Daemon release. After the
> recent flurry of activity and a couple of failed RCs, it is time for
> another release vote.
>
> Notable changes since 1.1.0 include:
> - Improved JRE/JDK detection to support increased range of both JVM
> versions and vendors.
> - Procrun. Minimum target platform for Windows binaries is now Windows 7
> - Procrun. Change the default service from LocalSystem to
> 'NT Authority\LocalService'
>
> The full set of changes is in the changelog
>
> 1.2.0 RC2 can be obtained from (r34680):
> https://dist.apache.org/repos/dist/dev/commons/daemon/
>
> The git tag is:
> Tag: COMMONS_DAEMON_1_2_0_RC2
> URL:
> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=d88fd9100c1110fa51b7c7a08e3e7efd0e58227b
> Hash: d88fd9100c1110fa51b7c7a08e3e7efd0e58227b
>
> The Maven Staging repo is:
> https://repository.apache.org/content/repositories/orgapachecommons-1443/
>
> The Windows binaries have been signed by the Symantec code signing service.
>
> Files signed with my preferred key:
> http://people.apache.org/~markt/
> KEYS file is standard Apache Commons keys file:
> http://www.apache.org/dist/commons/KEYS
>
>
> [ ] Approved - go ahead and release Commons Daemon 1.2.0 RC2 as 1.2.0
> [ ] Broken - do not release because...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
