Adam, I think Geoff just answered this question for us. I'll go back and check the Travis logs to see which tests were actually skipped. If they were just the JNA tests then it's probably not much of a problem.
On Mon, Apr 27, 2020 at 9:44 AM Adam Retter <adam.ret...@googlemail.com.invalid> wrote: > > Thanks Alex, > > I don't have a great deal of time available to look into this. If > someone could assure me that this compiles, and all the tests run > correctly on their MacOS with LibreSSL first, then I could then figure > out the difference on Travis. I suspect it is a more general Mac issue > than just Travis, as the Travis Mac environment is fairly standard. > > On Mon, 27 Apr 2020 at 14:53, Alex Remily <alex.rem...@gmail.com> wrote: > > > > Adam, > > > > Fair points. I don't know if commons-crypto "officially" supports > > LibreSSL, but now that I think about it, it may be a moot point. As > > long as LibreSSL complies with the OpenSSL 1.0 or 1.1 API, it *should* > > run. It did compile and build against LibreSSL on the Mac, and the > > tests didn't fail--they were skipped because commons-crypto couldn't > > find the native libraries for JNI. I think the issue is probably an > > environment variable or path that needs to be set so commons-crypto > > can find the native binaries. The tests may well pass if the native > > library is present. Even if they don't, at least we'd know. Would > > you be willing to troubleshoot that on Travis? If so, I'd recommend > > checking out the NativeCodeLoader class. > > > > Marcelo is more familiar with the application than I am, so maybe he > > can give some pointers. > > > > @Marcelo - Any suggestions? > > > > Alex > > > > > > Alex > > > > On Mon, Apr 27, 2020 at 7:10 AM Adam Retter > > <adam.ret...@googlemail.com.invalid> wrote: > > > > > > Hi Alex, > > > > > > > Just submitted a PR to increase the coverage in the streams package. > > > > While prepping the PR I noticed the Travis Mac build is testing > > > > against LibreSSL > > > > > > I recently improved the Travis builds for a few platforms, however > > > libressl on Mac OS has been the case since before I was involved. > > > Looking back through the Git history it looks like it has been this > > > way since October 2018 - > > > https://github.com/apache/commons-crypto/commit/c5c6220c2509c4d12de3fc08d591f82b89f882a0#diff-354f30a63fb0907d4ad57269548329e3 > > > > > > Whilst it is possible with some manual work to install OpenSSL on > > > MacOS, and I could make this happen in the Travis builds if you > > > wish... this feels a bit unfriendly to users to me, as of course most > > > Java users just add the Jar dependency and get going without a second > > > thought ;-) > > > So I just wanted to check some stuff with you first. > > > > > > The README.md does not make it very clear that OpenSSL is required on > > > MacOS, it says: > > > > > > 4. JNI-based implementation to achieve comparable performance to the > > > native C/C++ version based on OpenSsl. > > > 5. Portable across various operating systems (currently only > > > Linux/MacOSX/Windows); Apache Commons Crypto loads the library > > > according to your machine environment (it checks system properties, > > > os.name and os.arch). > > > 6. Simple usage. Add the commons-crypto-(version).jar file to your > > > classpath. > > > > > > So I guess my question is - Does commons-crypto only support OpenSSL, > > > and there is no plan to change that?. If so then I can make the > > > changes on Travis for you, and I think we must improve the README.md > > > so it is clear that Mac users have to manually install OpenSSL and > > > override LibreSSL if they want to use the JNI part of Commons Crypto. > > > > > > > > > Cheers Adam. > > > > > > > > > > > > -- > > > Adam Retter > > > > > > skype: adam.retter > > > tweet: adamretter > > > http://www.adamretter.org.uk > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > -- > Adam Retter > > skype: adam.retter > tweet: adamretter > http://www.adamretter.org.uk > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
