Hi Gary, I'm looking through the Jacoco report and see that some of the low coverage is coming from the following: 1. Not being able to cover the native classes, listing them as 0% 2. OpenSSL 1.1.x and 1.0.x, depending on the build env, only 1 will be covered 3. Some conditional statements are Arch and OS specific, so are not hit depending on the build env. 4. Some classes have API stubs that are not used, but still count against coverage. 5. Lack of tests...
I can help with building on different platforms for 2 and 3, then merge the reports using jacoco:merge to see what coverage we ultimately get, but not sure I can really help with 4 and 5 as I have little knowledge of the API exposed by commons-crypto. There is nothing that can be done for 1. Overall, the coverage is 71% when building on RHEL8 for x86_64 and AArch64 after merging. - Geoff P.S. It looks like javah used by the build system is deprecated, at some point the build system needs to take this into account. I could not build on my Mac using brew to install dependencies as the JDK stack I get is too new. On Sun, Apr 12, 2020 at 10:53 AM Gary Gregory <garydgreg...@gmail.com> wrote: > > On Sun, Apr 12, 2020 at 10:49 AM Geoffrey Blake <geoffrey.w.bl...@gmail.com> > wrote: > > > Gary, Alex, > > > > Let me know what else needs doing. > > > Hi All: > > See my previous email WRT code coverage using JaCoCo. > > > > I can certainly help with building > > artifacts, just need guidance on minimum distro and Java to use. > > > > Thank you for the offer. I plan on doing the building and releasing, which > will be all based on what the pom and makefiles provide as currently in git > master. > > > > The 1.0 release on maven central only included linux32 and linux64 native > > libs, even though the Makefile supports many more targets > > > > Please see the snapshot builds which now include more: > https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-crypto/1.1.0-SNAPSHOT > > If you want more in there, you'll have to provide a PR. > > I am building on: > > Linux US-L-GG02 4.4.0-43-Microsoft #1-Microsoft Wed Dec 31 14:42:53 PST > 2014 x86_64 x86_64 x86_64 GNU/Linux > > Within Microsoft Windows [Version 10.0.16299.1747] > > With: > > gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 > > GNU Make 4.1 > Built for x86_64-pc-linux-gnu > > g++ (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 > > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) > Maven home: /mnt/c/Java/apache-maven-3.6.3 > Java version: 1.8.0_242, vendor: Private Build, runtime: > /usr/lib/jvm/java-8-openjdk-amd64/jre > Default locale: en, platform encoding: UTF-8 > OS name: "linux", version: "4.4.0-43-microsoft", arch: "amd64", family: > "unix" > > Thanks! > Gary > > > > > > -Geoff > > > > On Sun, Apr 12, 2020 at 9:17 AM Gary Gregory <garydgreg...@gmail.com> > > wrote: > > > > > On Sat, Apr 11, 2020 at 1:55 PM Alex Remily <alex.rem...@gmail.com> > > wrote: > > > > > > > This looks to be done. I added a comment to the ticket with a link to > > > the > > > > commit. > > > > > > > > > > > > > > > > > https://github.com/apache/commons-crypto/commit/3466943e4552474ab681d7852dbfa62c74d8e1ce > > > > > > > > > Thanks Alex, I resolved the parent ticket and added it to changes.xml. > > > > > > When I run tests and look at code coverage JaCoCo report, it does not > > look > > > great IMO: > > > > > > mvn -V clean install site -P jacoco -P japicmp > > > > > > Then open the site in target/site > > > > > > Is there any chance you can improve on this? > > > > > > Thank you, > > > Gary > > > > > > > > > > > > > > > > > Alex > > > > > > > > On Sat, Apr 11, 2020 at 11:54 AM Gary Gregory <garydgreg...@gmail.com> > > > > wrote: > > > > > > > > > On Sat, Apr 11, 2020 at 8:43 AM Gary Gregory <garydgreg...@gmail.com > > > > > > > > wrote: > > > > > > > > > > > On Fri, Apr 10, 2020 at 8:38 PM Marcelo Vanzin <van...@apache.org> > > > > > wrote: > > > > > > > > > > > >> (-CCs) > > > > > >> > > > > > >> Hi Gary, thanks for volunteering to help. If needed I can try > > > helping > > > > > with > > > > > >> the release process (e.g. uploading artifacts), but I don't really > > > > have > > > > > >> the > > > > > >> ability to build anything but the linux64 native lib (maybe the > > > > linux32 > > > > > >> one > > > > > >> if I can find the right packages or docker image). > > > > > >> > > > > > > > > > > > The ticket: > > > > > > > > > > https://issues.apache.org/jira/browse/CRYPTO-59 > > > > > > > > > > refers to the incomplete subtask: > > > > > > > > > > https://issues.apache.org/jira/browse/CRYPTO-126 > > > > > > > > > > May you complete this task with a PR on GitHub? If it is already > > done, > > > > then > > > > > please update the ticket with what classes and methods perform the > > > tests. > > > > > > > > > > Thank you, > > > > > Gary > > > > > > > > > > > > > > > > > > > > > > > > > > >> I looked at the 1.0 release and it seems to include linux32/64, > > > > win32/64 > > > > > >> and macos64. > > > > > > > > > > > > > > > > > > You can review what is in git master or what I also pushed as a > > > > snapshot > > > > > > build to > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-crypto/1.1.0-SNAPSHOT > > > > > > > > > > > > > > > > > >> > > > > > >> src/changes/changes.xml probably needs some love too. > > > > > >> > > > > > > > > > > > > Indeed, this file was not updated with each change. It needs > > > updates. A > > > > > PR > > > > > > is welcome or a message here confirming that all JIRAs listed on > > > > > > https://issues.apache.org/jira/projects/CRYPTO/versions/12335578 > > are > > > > > > indeed in git master. Then I can update the changes.xml if no one > > > > > submits a > > > > > > PR. > > > > > > > > > > > > Gary > > > > > > > > > > > > > > > > > >> > > > > > >> > > > > > >> On Fri, Apr 10, 2020 at 5:02 PM Gary Gregory < > > > garydgreg...@gmail.com> > > > > > >> wrote: > > > > > >> > > > > > >> > I'll see what I can do over the weekend. > > > > > >> > > > > > > >> > Gary > > > > > >> > > > > > > >> > > > > > > >> > On Thu, Apr 9, 2020 at 8:45 PM Alex Remily < > > alex.rem...@gmail.com > > > > > > > > > >> wrote: > > > > > >> > > > > > > >> >> Commons Crypto Team, > > > > > >> >> > > > > > >> >> It's been four years since the last release of commons crypto. > > > > There > > > > > >> have > > > > > >> >> been many updates to the repository since then, notably the > > > > > >> integration of > > > > > >> >> OpenSSL 1.1.1, and native arm64 support. Geoff Blake (copied) > > > and > > > > I > > > > > >> have > > > > > >> >> been advocating for a new release, and we need assistance from > > > > > someone > > > > > >> who > > > > > >> >> knows the release process and has the necessary accesses. If > > any > > > > of > > > > > >> you > > > > > >> >> are willing to assist with this effort, please come up on the > > > > apache > > > > > >> >> commons dev list (also copied) and announce yourself. > > > > > >> >> > > > > > >> >> Looking forward to hearing from you. > > > > > >> >> > > > > > >> >> Alex > > > > > >> >> > > > > > >> > > > > > > >> > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
