Hi. Le dim. 7 juin 2020 à 12:54, Xeno Amess <xenoam...@gmail.com> a écrit : > > Ahhh you are right. > I'm new to JIRA. sorrrrry
I'll take the opportunity to draw your attention to pending issues in "Commons Math"[1] that would prevent releasing the next version. It's great that you want to clean up the codebase, but the myriad of little adjustments (among the few significant enhancements) will not make the release happen sooner. I hope that you can find something interesting to work on from the list below (to which you can add of course by filing new JIRA reports). As for the clean-up, I strongly suggest to create *one* report that will list all suggestions/PRs for small improvements sorted in categories (with *one* JIRA "sub-task" per category). That way, a reviewer can take on a single type of issue, quickly figuring out what the change is about, in every commit. A single "target" issue on JIRA would also allow to normalize/simplify/improve the commit message. For example, a message such as this one: ---CUT--- refine equals from ClassCastException ---CUT--- is not to the point and one is clueless without actually looking at the diff. This kind of issue should rather lead to a "Do not use exception for control flow" category. [Then the commit message would be just that (prefixed with the JIRA issue identifier).] The current flood of email messages from GitHub is not sustainable for me (sorry). Thanks, Gilles [1] https://issues.apache.org/jira/projects/MATH/issues > Gilles Sadowski <gillese...@gmail.com> 于2020年6月7日周日 下午6:50写道： > > > Hi. > > > > 2020-06-07 8:21 UTC+02:00, Xeno Amess <xenoam...@gmail.com>: > > > If you are telling about 144: > > > yes, original codes runs like: > > > f[0] = f0; > > > f[1] = f1; > > > f[2] = f[2-2] = f[0] = f[0] > > > f[3] = f[3-2] = f[1] = f[1] > > > f[4] = f[4-2] = f[2] = f[0] > > > f[5] = f[5-2] = f[3] = f[1] > > > > > > the new codes runs like: > > > f[0] = f0; > > > f[1] = f1; > > > f[2] = 2&1==0 ? f0 : f1 = f0 > > > f[3] = 3&1==0 ? f0 : f1 = f1 > > > f[4] = 4&1==0 ? f0 : f1 = f0 > > > f[5] = 5&1==0 ? f0 : f1 = f1 > > > > > > thus it runs faster for around 7% faster on my performance tests. > > > > > > > Wrong thread. > > Please reply on JIRA, where this discussion should be taking place.[1] > > > > Regards, > > Gilles > > > > [1] https://issues.apache.org/jira/browse/MATH-1538 > > > > > > > > > > > Gilles Sadowski <gillese...@gmail.com> 于2020年6月7日周日 上午5:53写道： > > > > > >> Hi. > > >> > > >> 2020-06-06 14:21 UTC+02:00, Xeno Amess <xenoam...@gmail.com>: > > >> > Alright, done. > > >> > This pr is now splitted into two prs. > > >> > https://github.com/apache/commons-math/pull/144 > > >> > https://github.com/apache/commons-math/pull/143 > > >> > > >> I think that there are issues with some of the changes (e.g. where > > >> the previous code used an "index" variable but in the new version > > >> there is a hard-coded number). > > >> > > >> Gilles > > >> > > >> > [...] > > >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
