Hello Gilles, On Sat, Jun 13, 2020 at 6:36 PM Gilles Sadowski <gillese...@gmail.com> wrote:
> Hello. > > After the migration from SVN to "gitbox", we noticed that the > _first_ build failed due to 3 unit tests not passing (see e.g. the > Travis report referred to the JIRA report[1]). > > The move to "git" was intended to make it easier for people > willing to revive the [Graph] project. > > IMO, the top priority is now to fix the failing unit tests; > personally, I'm not going to merge any PR before that is > achieved (and please refer to the JIRA identifier[1] in the > corresponding commit/PR). > Indeed, that's what I think too. I have tried to stop bleeding commons-graph for now PR https://github.com/apache/commons-graph/pull/3, along with some more small nitty-gritty. > Furthermore, I'd suggest that branch "modularization" > becomes the reference branch (in place of "master"[2]), > since the latest batch of work for [Graph] was done on > that one, seemingly leaving "master" behind (TBC by > Amey?). [This path might avoid subsequent work of > merging the fixed (but outdated) "master" into the more > recent branch that is bound to replace it anyway...] > I am on the way to push my changes to master regarding modularization. I have more intention to push changes in master now. 1. I have just stopped bleeding due to failing test cases, with TODO marking though, so we can pull this work later once the "modularized" version of the comons-graph becomes stable in "master". 2. I'm comparing each and every class from master to a modularized version of graph to make sure we don't miss anything behind from master. 3. we should not take my merge in functional code in the meantime, other related to Travis, Builds, Coverall is ok to accept as it doesn't interfere with /src. Regards, Amey > > Thanks, > Gilles > > [1] https://issues.apache.org/jira/browse/SANDBOX-510 > [2] Even though the names of the maven "modules" should > be changed (for the sake of code layout "standardization" > with other modular components such as "Commons RNG"). > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
