Hello. Le mer. 5 oct. 2022 à 12:25, Alex Herbert <aherb...@apache.org> a écrit : > > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons RNG 1.4 was released, so I would like to release > Apache Commons RNG 1.5. > > Apache Commons RNG 1.5 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1 (svn > revision 57177) > https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/ > > The Git tag commit for this RC is commons-rng-1.5-RC1 which you can browse > here: > > https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commit;h=commons-rng-1.5-RC1 > > You may checkout this tag using: > git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch > commons-rng-1.5-RC1 commons-rng-1.5-RC1 > (signature can be checked from git using 'git tag -v commons-rng-1.5-RC1')
Tag checked. > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/ > > These are the artifacts and their hashes: > > #Release SHA-512s > #Tue Oct 04 13:00:24 BST 2022 > commons-rng-1.5-bin.tar.gz=9e98092cb123a1873cc4ab05ebd87681b9f5fe171ad53cd00488c33e0ab2c7fb8a0bdd9c903a3bde7bc2e4f4035b07cf223b0d921e35d00fcea226ec16f86b5c > commons-rng-1.5-bin.zip=ad01629da0ef089641c4a7a8fed8e2dd9f1ed0fec3e9cc6fd19df22e0516bc8c1a4699a8d2104b5878a13ad9fbec724b85ca0a71c1e3027673cbcab8a5911b30 > commons-rng-1.5-src.tar.gz=7fdfcd9ee43ac51f73eb6781d8fae7f313bf20658af84383ff791779def56c690458b99f2e996ce7fec8588db3218f23eea6dc6c2ff7d692f4209b78eb4b4dd8 > commons-rng-1.5-src.zip=e1624601d449eecca660839b592c4deb7386ef77a09d613002e8220149f244cbb5bc70c08100fe27eb0d448efea7aef8ac1ebe26f416d846ba3bccd4f43d82e5 > > Signatures may be validated on a system supporting a bash unix shell by > executing: > svn co https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/ > cd 1.5-RC1 > chmod +x ./signature-validator.sh > for m in client-api core simple sampling bom; do > ./signature-validator.sh > https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/commons-rng-${m}/1.5/; > done The output of this script without argument ends with ---CUT--- SUCCESSFUL VALIDATION ---CUT--- [Of course there are also hints that something went wrong, but the final line is misleading.] Suggestions: 1. Could the validating script be tailored to the corresponding release (i.e. the above lines would be included (together with code that collects all errors if multiple artefacts/modules must be checked)? [The script itself would thus change for each component and release.] 2. The above command line (bash loop) fails (although reporting success as noted above) because the URL is not on the same line as ./signature-validator.sh Signatures checked. > [...] > > I have tested this with 'mvn clean package site site:stage > -Pcommons-rng-examples' using: > > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) > Maven home: /usr/local/apache-maven-3 > Java version: 11.0.16, vendor: Ubuntu, runtime: > /usr/lib/jvm/java-11-openjdk-amd64 > Default locale: en_GB, platform encoding: UTF-8 > OS name: "linux", version: "4.15.0-193-generic", arch: "amd64", family: > "unix" Build successful: $ mvn -v Apache Maven 3.6.3 Maven home: /usr/share/maven Java version: 11.0.16, vendor: Debian, runtime: /usr/lib/jvm/java-11-openjdk-amd64 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.10.0-17-amd64", arch: "amd64", family: "unix" > > Details of changes since 1.4 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/RELEASE-NOTES.txt > > https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/changes-report.html > > Site: > https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/index.html > (note some *relative* links are broken and the 1.5 directories are not > yet created - these will be OK once the site is deployed.) Still wondering why the (expectedly broken) site is part of the release review... [It is possible to break the site afterwards too anyways ;-).] > > [...] > > RevApi Report (compared to 1.4): > > https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-client-api/revapi-report.html > > https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/revapi-report.html > > https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-simple/revapi-report.html > > https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-sampling/revapi-report.html Checked that the only changes reported as breaking are in package org.apache.commons.rng.simple.internal > RAT Report: > > https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/rat-report.html Checked. > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner than 72 hours from now. > [X] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > Thank you, Gilles > [...] --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
