On Fri, 21 Oct 2022 at 11:57, <sma...@outlook.de> wrote: > > > Would't it be simpler to deal with the serialization issue by bumping the > > serialVersionID? > simpler yes, but it's a different thing > The PR makes the serialized forms for commons-csv versions 1.9.0 and 1.10.0 > compatible. > > Given that serialization has been broken for several versions in commons-csv > and given that "fixing" it now is a labor of love which does not add much > value, > I am in favor of throwing it out altogether now rather than in some future > (major) version. Clearly inform about it in the release notes and be done > with it.
+1 > > Also note the PR will throw an NPE in the builder > > when instead of using the validate() method. > > setDuplicateHeaderMode(null) is illegal and should be fail-fast IMO > > kind regards, > Markus > > From: Gary Gregory <garydgreg...@gmail.com> > Sent: Thursday, October 20, 2022 16:43 > To: Commons Developers List <dev@commons.apache.org> > Subject: Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1 > > Would't it be simpler to deal with the serialization issue by bumping the > serialVersionID? We can just say that you only serialized and deserialize > for the same version. Also note the PR will throw an NPE in the builder > when instead of using the validate() method. > > Gary > > On Wed, Oct 19, 2022, 18:27 Gary D. Gregory <ggreg...@apache.org> wrote: > > > I've commented on the PR. > > TY. > > Gary > > > > On 2022/10/19 16:51:57 Gary Gregory wrote: > > > On Wed, Oct 19, 2022 at 10:01 AM Alex Herbert <alex.d.herb...@gmail.com> > > wrote: > > > > > > > > On Wed, 19 Oct 2022 at 14:57, Gary D. Gregory <ggreg...@apache.org> > > wrote: > > > > > > > > > > My +1 > > > > > > > > > > Gary > > > > > > > > Gary, > > > > > > > > PR #276 highlights a behavioural compatibility error in the 1.10.0 RC1. > > > > > > > > AllowDuplicates enum may be set to the incorrect value when setting > > > > the allow duplicates boolean. Have you reviewed this? I believe it is > > > > valid. > > > > > > I will re-read later tonight... > > > > > > Gary > > > > > > > > > > > Alex > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
