The OSGi tests we have do pass but they might not be touching all the right places.
Gary On Sat, Feb 24, 2024, 6:23 AM Elliotte Rusty Harold <[email protected]> wrote: > It looks like this has been partially fixed at head. The Maven > dependency on commons-io is no longer marked as optional. However the > OSGI dependencies are still optional. It's been a few years since I > last had to think about OSGI. I'm not sure if this is likely to break > anyone or not. > > On Sat, Feb 24, 2024 at 2:16 PM Elliotte Rusty Harold > <[email protected]> wrote: > > > > FYI optional dependency on commons-io is also breaking dependents: > > > > > https://github.com/apache/maven-assembly-plugin/pull/187#pullrequestreview-1899505395 > > > > These dependencies really shouldn't be optional. > > > > On Thu, Feb 22, 2024 at 12:08 PM Andrew Coates > > <[email protected]> wrote: > > > > > > Hi all, > > > > > > I'm seeing a runtime failure using TarArchiveOutputStream when > updating to > > > commons-compress 1.26.0. > > > > > > java.lang.NoClassDefFoundError: org/apache/commons/codec/Charsets > > > at [email protected] > > > > /org.apache.commons.compress.archivers.tar.TarArchiveOutputStream.<init>(TarArchiveOutputStream.java:212) > > > at [email protected] > > > > /org.apache.commons.compress.archivers.tar.TarArchiveOutputStream.<init>(TarArchiveOutputStream.java:157) > > > at [email protected] > > > > /org.apache.commons.compress.archivers.tar.TarArchiveOutputStream.<init>(TarArchiveOutputStream.java:147) > > > at [email protected] > > > > /org.testcontainers.containers.ContainerState.copyFileToContainer(ContainerState.java:350) > > > ... > > > > > > Commons-compress 1.26.0 contains changes to make use of commons-codec, > > > rather than its own copy of files, but I see that the POM marks > > > commons-codec as *optional*. Excuse my potential ignorance, but I > thought > > > optional dependencies shouldn't cause runtime failures if not > present. Is > > > this not the case? > > > > > > Obviously, I can just add commons-codec as an explicit dependency. But > this > > > seems wrong IMHO. > > > > > > Should I sign up for an account and raise this as a bug in Jira? > > > > > > Thanks, > > > > > > Andy > > > > > > > > -- > > Elliotte Rusty Harold > > [email protected] > > > > -- > Elliotte Rusty Harold > [email protected] > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
