[
https://issues.apache.org/jira/browse/COMMONSRDF-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15542486#comment-15542486
]
ASF GitHub Bot commented on COMMONSRDF-33:
------------------------------------------
Github user stain commented on the issue:
https://github.com/apache/incubator-commonsrdf/pull/23
Hmm.. Removing `JenaVariable` means in `fromJenaGeneralized(Node)` I have
to fail on `node.isVariable()` (which [is in the Jena
API](https://jena.apache.org/documentation/javadoc/jena/org/apache/jena/graph/Node.html#isVariable--)):
e.g. current suggestion
```java
if (node.isVariable()) {
return new JenaVariableImpl(node);
}
```
will instead become:
```java
throw new IllegalArgumentException("Unrecognized node type: " + node);
```
@afs - how generalized should I make the generalized quad? :)
> Jena integration
> ----------------
>
> Key: COMMONSRDF-33
> URL: https://issues.apache.org/jira/browse/COMMONSRDF-33
> Project: Apache Commons RDF
> Issue Type: New Feature
> Reporter: Stian Soiland-Reyes
> Assignee: Stian Soiland-Reyes
> Fix For: 0.3.0
>
>
> Add a new jena/ module with implementations mapping to Jena 3.x
> Based on JENA-1015, https://github.com/afs/commonsrdf-jena and
> https://github.com/stain/incubator-commonsrdf/tree/jena
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
