[ 
https://issues.apache.org/jira/browse/COMMONSRDF-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552231#comment-15552231
 ] 

ASF GitHub Bot commented on COMMONSRDF-33:
------------------------------------------

Github user afs commented on a diff in the pull request:

    https://github.com/apache/incubator-commonsrdf/pull/23#discussion_r82216157
  
    --- Diff: 
jena/src/main/java/org/apache/commons/rdf/jena/ConversionException.java ---
    @@ -0,0 +1,47 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.commons.rdf.jena;
    +
    +import org.apache.jena.shared.JenaException;
    +
    +/**
    + * Exception thrown when a problem arises across the Jena-CommonRDF 
boundary.
    + * This should not happen in well-formed RDF data but, for example, Jena 
triples
    + * allow
    + * <a href="http://www.w3.org/TR/rdf11-concepts/#section-generalized-rdf"; >
    + * generalized RDF</a>.
    + */
    +
    +public class ConversionException extends JenaException {
    +   public ConversionException() {
    --- End diff --
    
    As this is thrown going from Jena to Commons RDF, shouldn't be a CommonsRDF 
exception?  i.e. the app code does "try { ... } catch (CommonsRDFException)" 
not "catch (JenaException)" because it's jena-independent at that point?


> Jena integration
> ----------------
>
>                 Key: COMMONSRDF-33
>                 URL: https://issues.apache.org/jira/browse/COMMONSRDF-33
>             Project: Apache Commons RDF
>          Issue Type: New Feature
>            Reporter: Stian Soiland-Reyes
>            Assignee: Stian Soiland-Reyes
>             Fix For: 0.3.0
>
>
> Add a new jena/ module with implementations mapping to Jena 3.x
> Based on JENA-1015, https://github.com/afs/commonsrdf-jena and 
> https://github.com/stain/incubator-commonsrdf/tree/jena



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to