[
https://issues.apache.org/jira/browse/COMMONSRDF-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15543899#comment-15543899
]
ASF GitHub Bot commented on COMMONSRDF-35:
------------------------------------------
Github user ansell commented on a diff in the pull request:
https://github.com/apache/incubator-commonsrdf/pull/24#discussion_r81657373
--- Diff: rdf4j/src/main/java/org/apache/commons/rdf/rdf4j/RDF4JQuad.java
---
@@ -0,0 +1,28 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.rdf.rdf4j;
+
+import org.apache.commons.rdf.api.Quad;
+
+/**
+ * Marker interface for RDF4J implementations of Quad.
+ *
+ */
+public interface RDF4JQuad extends Quad, RDF4JTripleLike {
--- End diff --
In practice, RDF4J only supports RDF-1.1 `Quad`'s in terms of the equals
contract. Ie, if a context is missing it is assumed to be the default graph and
still a `Statement` or `Quad`. Ie, in RDF4J the Statement.getContext() for the
equals contract is always present, and just represents the default graph if it
is null.
Knowing that may simplify the implementation here as there is no need to
deal with `RDF4JTriple`/`Triple`/`RDF4JTripleLike`/`TripleLike`, or Generalised
RDF given that restriction and you can just focus everything on `Quad`.
The contract for Statement.equals changed in RDF4J compared to Sesame,
where the graph was always not used for .equals, making any implementation of
Commons RDF for Sesame distinctly different to RDF4J:
https://github.com/eclipse/rdf4j/blob/master/core/model/src/main/java/org/eclipse/rdf4j/model/Statement.java#L47
> rdf4j integration
> -----------------
>
> Key: COMMONSRDF-35
> URL: https://issues.apache.org/jira/browse/COMMONSRDF-35
> Project: Apache Commons RDF
> Issue Type: New Feature
> Reporter: Stian Soiland-Reyes
> Assignee: Stian Soiland-Reyes
> Labels: integration, rdf4j, sesame
> Fix For: 0.3.0
>
>
> Add a new rdf4j module with implementation for Eclipse rdf4j
> See https://github.com/apache/incubator-commonsrdf/tree/rdf4j/rdf4j
> A legacy sesame branch could then be added by mainly copy/paste and change
> the import
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
