Github user ajs6f commented on the issue:
https://github.com/apache/incubator-commonsrdf/pull/26
Generally, looks good to me. The questions I have are:
1. Do we need to talk about `equals` and `hasCode` separately?
2. Can we clarify the definition of "immutable" a bit: most people, I
think, would assume that it means that e.g. `Quad::getSubject` is actually
going to return the identical object, not an `equals` object. I'm not against
the definition you are using here, and I can understand how it might give a
useful flexibility during implementation, but it might be nice to have a
higher-level note explaining it carefully.
3. I think there could be a use of `default` methods here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
