Github user ansell commented on a diff in the pull request:
https://github.com/apache/incubator-commonsrdf/pull/25#discussion_r85231845
--- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java ---
@@ -31,7 +31,7 @@
* and <a href="https://en.wikipedia.org/wiki/TriX_%28syntax%29";>TriX</a>.
*
* @see <a
href="https://www.w3.org/TR/rdf11-primer/#section-graph-syntax";>RDF 1.1
Primer</a>
- *
+ * @see org.apache.commons.rdf.experimental.RDFParser
*/
public enum RDFSyntax {
--- End diff --
Sorry, this comment is unrelated to the RDF change but I didn't notice this
previously.
Using enum for RDFSyntax is a bad idea unless it overrides an interface and
the interface is used in method signatures instead of the enum. There are many
other RDFSyntaxes, and enum (without implementing an interface) is only suited
to cases where the full set are known a priori.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
