Github user ansell commented on a diff in the pull request:
https://github.com/apache/incubator-commonsrdf/pull/25#discussion_r85233507
--- Diff:
api/src/test/java/org/apache/commons/rdf/api/AbstractRDFTermFactoryTest.java ---
@@ -208,8 +172,8 @@ public void testCreateIRIRelative() throws Exception {
// be possible to resolve to an absolute IRI)
try {
factory.createIRI("../relative");
- } catch (UnsupportedOperationException | IllegalArgumentException
ex) {
- Assume.assumeNoException(ex);
+ } catch (IllegalArgumentException ex) {
+ Assume.assumeNoException("Relative IRIs not supported - ignore
this test", ex);
--- End diff --
createIRI and RDF do not have facilities for setting or accessing base
IRIs. RDF-1.1 only recognises Absolute IRIs. It only references relative IRIs
in relation to concrete formats, and factory is not dealing with concrete
formats, only the abstract model. Adding functionality for relative IRIs to the
experimental parser interfaces could be useful, but no point in testing it
here.
Ie, if the result of RDF.createIRI can legally return a relative IRI, it
may not be portable with all other implementations, so this Assume is masking
an interoperability concern. If Commons RDF is to be useful it needs to be
portable for all of its core features, of which IRI is one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
