[
https://issues.apache.org/jira/browse/COMMONSRDF-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15675062#comment-15675062
]
ASF GitHub Bot commented on COMMONSRDF-47:
------------------------------------------
Github user ansell commented on a diff in the pull request:
https://github.com/apache/incubator-commonsrdf/pull/27#discussion_r88565369
--- Diff:
simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java
---
@@ -240,7 +240,7 @@ public T rdfTermFactory(RDF rdfTermFactory) {
public T contentType(RDFSyntax rdfSyntax) throws
IllegalArgumentException {
AbstractRDFParser<T> c = clone();
--- End diff --
Is it actually necessary to clone here? The typical builder pattern is much
simpler with its reliance on always having "return this" as its last line, and
using mutation before the "build()" terminal method to reduce this horrendous
complexity related to cloning longterm mutable objects.
> RDFSyntax should be interface, not enum
> ---------------------------------------
>
> Key: COMMONSRDF-47
> URL: https://issues.apache.org/jira/browse/COMMONSRDF-47
> Project: Apache Commons RDF
> Issue Type: Bug
> Components: api
> Affects Versions: 0.2.0
> Reporter: Stian Soiland-Reyes
> Assignee: Stian Soiland-Reyes
>
> [~p_ansell] raises in [pull request
> 25|https://github.com/apache/incubator-commonsrdf/pull/25#discussion_r85231845]
> {quote}
> Using enum for RDFSyntax is a bad idea unless it overrides an interface and
> the interface is used in method signatures instead of the enum. There are
> many other RDFSyntaxes, and enum (without implementing an interface) is only
> suited to cases where the full set are known a priori.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
