Wut! Go for it. The Java code may need to be modified but I've clearly marked it in the InAppBrowser.java class with TODO's. Simon Mac Donald http://hi.im/simonmacdonald
On Wed, Nov 28, 2012 at 4:29 PM, Shazron <shaz...@gmail.com> wrote: > No worries Simon - I'll add the support to the InAppBrowser window object. > Maybe I will even make some Android commits ;) > > > On Wed, Nov 28, 2012 at 12:46 PM, Simon MacDonald <simon.macdon...@gmail.com >> wrote: > >> I didn't get a ton of time to work on it but I posted a commit that calls >> the >> >> loadstart >> loadstop >> exit >> >> events on the window object. The main window object not the >> InAppBrowser window object. I know that will need to be fixed but it >> gave me the ability to do some testing. >> >> Plug away at the JS changes as I will be in Toronto Thursday and >> Friday on vacation. So I'll pick them up when I get back. >> Simon Mac Donald >> http://hi.im/simonmacdonald >> >> >> On Wed, Nov 28, 2012 at 2:56 AM, Shazron Abdullah <shaz...@gmail.com> >> wrote: >> > I reckon we'll be doing the same bits for the js so ping me privately >> > or post here to discuss approach. >> > >> > On 2012-11-27, at 9:08 PM, Simon MacDonald <simon.macdon...@gmail.com> >> wrote: >> > >> >> Yeah, I will start on it tomorrow morning. I'm on vacation Thursday >> >> and Friday but this looks doable before 2.3.0 is out. >> >> Simon Mac Donald >> >> http://hi.im/simonmacdonald >> >> >> >> >> >> On Tue, Nov 27, 2012 at 5:31 PM, Shazron <shaz...@gmail.com> wrote: >> >>> Simon, Let's get this in for 2.3.0? >> >>> >> >>> >> >>> On Thu, Nov 22, 2012 at 10:53 AM, Simon MacDonald < >> simon.macdon...@gmail.com >> >>>> wrote: >> >>> >> >>>> Is this required for the 2.3.0 release? >> >>>> >> >>>> Simon Mac Donald >> >>>> http://hi.im/simonmacdonald >> >>>> >> >>>> >> >>>> On Wed, Nov 21, 2012 at 11:30 PM, Shazron <shaz...@gmail.com> wrote: >> >>>> >> >>>>> Great! Let's stick with one API, since we have Chrome members on the >> >>>>> Cordova team the choice is obvious :) >> >>>>> >> >>>>> >> >>>>> On Wed, Nov 21, 2012 at 8:06 PM, Andrew Grieve <agri...@chromium.org >> > >> >>>>> wrote: >> >>>>> >> >>>>>> Looks that way. Given how similar they are, I don't think it matters >> >>>>> which >> >>>>>> one we go with (or if we come up with our own event names), but >> it'd be >> >>>>>> good to follow the same pattern of having events and an API like >> >>>>>> canGoBack(), goForward(), etc. If they ever move to standardize, >> then >> >>>> we >> >>>>>> can follow suit. >> >>>>>> >> >>>>>> >> >>>>>> On Wed, Nov 21, 2012 at 7:18 PM, Shazron <shaz...@gmail.com> wrote: >> >>>>>> >> >>>>>>> Mozilla's 'locationchange' is similar to what we have for >> >>>> ChildBrowser, >> >>>>>> but >> >>>>>>> I don't see the equivalent in the Chrome example - I suppose it is >> >>>>>>> 'loadstop'? >> >>>>>>> >> >>>>>>> I suppose if we were to adopt either, it would go something like >> >>>> this: >> >>>>>>> >> >>>>>>> var iab = window.open('http://apache.org', '_blank'); >> >>>>>>> // Firefox >> >>>>>>> iab.addEventListener('locationchange', handleLocationChange); >> >>>>>>> // Chrome >> >>>>>>> iab.addEventListener('loadstop', handleLoadStop); >> >>>>>>> >> >>>>>>> // Firefox >> >>>>>>> function handleLocationChange(e) { >> >>>>>>> console.log('location changed to: ' + e.detail); >> >>>>>>> } >> >>>>>>> // Chrome >> >>>>>>> function handleLoadStop(e) { >> >>>>>>> console.log('location changed to: ' + e.url); >> >>>>>>> } >> >>>>>>> >> >>>>>>> On Wed, Nov 21, 2012 at 1:32 PM, Andrew Grieve < >> agri...@chromium.org >> >>>>> >> >>>>>>> wrote: >> >>>>>>> >> >>>>>>>> >> >>>>>>>> >> >>>>>>> >> >>>>>> >> >>>>> >> >>>> >> https://github.com/GoogleChrome/chrome-app-samples/blob/master/browser/browser.js >> >>>>>>> >> >>>>>> >> >>>>> >> >>>> >>
