Awesome Anis! I'll play with this tonight, thanks!
On Mon, Dec 3, 2012 at 8:46 PM, Anis KADRI <anis.ka...@gmail.com> wrote: > https://github.com/imhotep/WebNotifications > > For now requires one manual step (adding code to AppDelegate.m) until we > figure out a way to deal with it. > > > On Fri, Nov 30, 2012 at 8:48 AM, Filip Maj <f...@adobe.com> wrote: > >> Yes and probably yes >> >> For example, the postMessage API in Android plugins is not documented. >> This is essentially the same thing as what we are describing for iOS >> plugins. We could take this moment to document both in one fell swoop. >> >> On 11/30/12 2:09 AM, "Brian LeRoux" <b...@brian.io> wrote: >> >> >Would this be an appropriate addition to the plugin dev guide or are >> >there other events/scenarios we/re not considering? >> > >> >On Fri, Nov 30, 2012 at 6:57 AM, Filip Maj <f...@adobe.com> wrote: >> >> I feel pretty dumb not thinking about this before.. >> >> >> >> O well, good thing Jesse is smrt! >> >> >> >> On 11/29/12 7:21 PM, "Ally Ogilvie" <aogil...@wizcorp.jp> wrote: >> >> >> >>>Hi Chaps, >> >>> >> >>>For Cordova 1.9 we were able to receive these events without any >> >>>modification to the AppDelegate by registering for didFinishLaunching >> >>>notifications etc. in the class' load method. >> >>> >> >>> >> https://github.com/wcwynn/phonegap-plugin-localNotifications/blob/v1.9/i >> >>>os >> >>>/project/Plugins/LocalNotification/LocalNotification.m#L34 >> >>> >> >>>Party. >> >>> >> >>> >> >>>On Fri, Nov 30, 2012 at 8:16 AM, Brian LeRoux <b...@brian.io> wrote: >> >>> >> >>>> +1 to Jesse's suggestion of Party. And the events thing. >> >>>> >> >>>> On Thu, Nov 29, 2012 at 10:51 PM, Shazron <shaz...@gmail.com> wrote: >> >>>> > Ok this is the essence of what the previous threads I linked to guys >> >>>>:) >> >>>> > >> >>>> > >> >>>> > On Thu, Nov 29, 2012 at 1:43 PM, Jesse <purplecabb...@gmail.com> >> >>>>wrote: >> >>>> > >> >>>> >> Have the AppDelegate raise events when things like >> >>>> >> 'didReceiveLocalNotification' happen. >> >>>> >> Have plugins subscribe to the event. >> >>>> >> Party. >> >>>> >> >> >>>> >> >> >>>> >> On Thu, Nov 29, 2012 at 1:30 PM, Anis KADRI <anis.ka...@gmail.com> >> >>>> wrote: >> >>>> >> > It's tricky exactly because of that reason (i.e multiple plugins >> >>>> editing >> >>>> >> > the same files/methods). I don't see a clean solution to this >> >>>>problem. >> >>>> >> One >> >>>> >> > way would be to just apply the patch. If it fails, notify the >> >>>>user >> >>>>and >> >>>> >> > prompt them to apply the code manually. Bright minds out there, >> >>>>your >> >>>> >> > thoughts are welcome. >> >>>> >> > >> >>>> >> > >> >>>> >> > >> >>>> >> > >> >>>> >> > On Thu, Nov 29, 2012 at 12:39 PM, Filip Maj <f...@adobe.com> >> >>>>wrote: >> >>>> >> > >> >>>> >> >> I think I had discussions with someone about this particular >> >>>>feature. >> >>>> >> >> >> >>>> >> >> What about having empty stubs for these functions that some >> >>>>plugins >> >>>> need >> >>>> >> >> to hook into (I.e. didReceiveLocalNotification) and then have >> >>>>the >> >>>> >> tooling >> >>>> >> >> drop code in where necessary for these functions? This can be a >> >>>> slippery >> >>>> >> >> slope (multiple plugins battling over a single function) but not >> >>>> worth a >> >>>> >> >> shot? >> >>>> >> >> >> >>>> >> >> On 11/28/12 11:13 PM, "Anis KADRI" <anis.ka...@gmail.com> >> wrote: >> >>>> >> >> >> >>>> >> >> >On Wed, Nov 28, 2012 at 10:43 PM, Brian LeRoux <b...@brian.io> >> >>>>wrote: >> >>>> >> >> > >> >>>> >> >> >> would this not be an indication that we need to modify the >> >>>>plugin >> >>>> >> api? >> >>>> >> >> >> (code munging would be a bad code smell for a pluggable >> >>>> architecture >> >>>> >> >> >> imo) >> >>>> >> >> >> >> >>>> >> >> > >> >>>> >> >> >Yes. The current specification does not support this use case. >> >>>> >> >> >I can't seem to find a clean/elegant solution to the problem. >> >>>> diff'ing >> >>>> >> >> >does >> >>>> >> >> >not work well if there are multiple plugins appending code to >> >>>> existing >> >>>> >> >> >files. One option would just be to prompt the user to append >> >>>>the >> >>>> code >> >>>> >> >> >manually (but that would not be too cool with cordova-client). >> >>>> >> >> > >> >>>> >> >> >Shaz, I believe I understand that we can expand AppDelegate to >> >>>> support >> >>>> >> >> >even >> >>>> >> >> >more overrides (including the didReceiveLocalNotification) but >> >>>>I >> >>>> >> believe >> >>>> >> >> >the real issue here is appending code in general and this issue >> >>>>is >> >>>> not >> >>>> >> >> >limited to iOS. We can keep this on the backburner for now as >> >>>>it >> >>>>is >> >>>> not >> >>>> >> >> >required by most plugins. >> >>>> >> >> >> >>>> >> >> >> >>>> >> >> >>>> >> >> >>>> >> >> >>>> >> -- >> >>>> >> @purplecabbage >> >>>> >> risingj.com >> >>>> >> >> >>>> >> >>> >> >>> >> >>> >> >>>-- >> >>> [image: Wizcorp - Incorporated Wizards!] >> >>> Ally Ogilvie >> >>>Lead Developer for Mobile Devices >> >>> >> >>> >> >>> >> >>> wizcorp.jp >> >>> >> >>>3-10-14-6F, Higashi Nihombashi, Chuo-ku, 103-0004, Tokyo >> >>>Tel: (+81)3-4550-1448 - E-mail: aogil...@wizcorp.jp >> >> >> >>
