https://issues.apache.org/jira/browse/CB-3384


On Mon, May 13, 2013 at 8:53 PM, Andrew Grieve <agri...@chromium.org> wrote:

> Hey Joe,
>
> You're definitely right that these changes should have had an issue
> associated with them before being merged. That was on my plate for last
> week, but I never got around to it before going on vacation. The motivation
> DataResource is twofold:
>
> 1. To better centralize URL handling / stream opening so that resource:
> and asset: URLs are handled properly.
> 2. To let cordova-app-harness be able to munge URL loading. This is
> required so that it can load apps using the start page as defined in their
> config.xml.
>
> I'll create a JIRA issue for it now.
>
>
>
>
> On Mon, May 13, 2013 at 5:50 PM, Joe Bowser <bows...@gmail.com> wrote:
>
>> Hey
>>
>> I was currently looking at CB-2391, and I noticed that there were a
>> lot of code changes made here such that I have no idea where the code
>> that handles params actually is now.  It appears to be in this
>> DataResource API.  That being said, I have no idea how this is
>> supposed to work, since it just seems to open streams.
>>
>> Also, can we please have tickets attached to new features that are
>> added to the code.  I don't know what problem DataResource is trying
>> to solve, or where we're actually doing the URI parsing, if we're
>> doing any.
>>
>> Can anyone explain what happened here, this seems like a pretty big code
>> change.
>>
>> Joe
>>
>
>

Reply via email to