----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15775/#review29288 -----------------------------------------------------------
The code looks good -- I think we probably need a couple of unit tests as well though. At least: Test --source (and/or --src) Test --source (and/or --src) --link There should probably be tests for * Source directory exists * Source directory exists but the app is inside www/ * Source directory doesn't exist - Ian Clelland On Nov. 22, 2013, 2:45 a.m., Mark Koudritsky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15775/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 2:45 a.m.) > > > Review request for cordova. > > > Bugs: CB-4153 > https://issues.apache.org/jira/browse/CB-4153 > > > Repository: cordova-cli > > > Description > ------- > > Add --src & --link to "cordova create". > > Both --src and --source are accepted. > The path is passed via the lib.www.uri of the configuration object > that is later written to .cordova/config.json. > > Cordova will keep going into child www folder(s) of the provided path. > > > Diffs > ----- > > doc/help.txt 1019200 > src/cli.js 86477e4 > src/create.js 1fdc271 > > Diff: https://reviews.apache.org/r/15775/diff/ > > > Testing > ------- > > npm test; > cordova -d create TstApp --source=some/www --link > a bunch of other cordova commands in the app > > > Thanks, > > Mark Koudritsky > >
