----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15775/#review30753 -----------------------------------------------------------
src/config_parser.js <https://reviews.apache.org/r/15775/#comment58861> This seems unrelated to the goal of this change. src/create.js <https://reviews.apache.org/r/15775/#comment58863> we shouldn't need to give it a random ID, should we? Can you add a TODO about getting rid of the need for it? - Andrew Grieve On Dec. 20, 2013, 4:51 p.m., Mark Koudritsky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15775/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2013, 4:51 p.m.) > > > Review request for cordova. > > > Bugs: CB-4153 > https://issues.apache.org/jira/browse/CB-4153 > > > Repository: cordova-cli > > > Description > ------- > > Add --src & --link to "cordova create". > > Both --src and --source are accepted. > The path is passed via the lib.www.uri of the configuration object > that is later written to .cordova/config.json. > > Cordova will keep going into child www folder(s) of the provided path. > > > Diffs > ----- > > doc/help.txt 3361dd3 > e2e/create.spec.js 560f82a > spec/cli.spec.js 215c64c > spec/metadata/android_parser.spec.js 52fc78a > spec/metadata/ios_parser.spec.js b56ddce > spec/metadata/windows8_parser.spec.js 5117148 > spec/metadata/wp7_parser.spec.js 6dc0695 > spec/metadata/wp8_parser.spec.js 8cd1923 > src/cli.js 2916062 > src/config_parser.js b6293d8 > src/create.js f741e2f > src/metadata/wp8_parser.js 163d56b > > Diff: https://reviews.apache.org/r/15775/diff/ > > > Testing > ------- > > npm test; > cordova -d create TstApp --source=some/www --link > a bunch of other cordova commands in the app > > > Thanks, > > Mark Koudritsky > >