+1 to removing them. I suggest having a quick look to see if there were any modifications in each plugin's /test folder though.
@purplecabbage risingj.com On Wed, Jan 8, 2014 at 1:05 PM, David Kemp <drk...@google.com> wrote: > +1 to removing them. > Soon we will need to replace them all with the ones from mobilespec (sort > of) anyway. > > > > On Wed, Jan 8, 2014 at 3:53 PM, Andrew Grieve <agri...@chromium.org> > wrote: > > > Anyone object to me going through and deleting the stale copy of tests > > within plugins? > > > > > > On Wed, Jan 8, 2014 at 12:40 PM, Ian Clelland <iclell...@chromium.org > > >wrote: > > > > > They are out of sync, for sure. The mobile-spec tests should be > > considered > > > canonical, I think -- that's what is actually being run by the CI > server, > > > and by everyone who is doing manual testing, as far as I know. (Anyone > > who > > > knows different: now is the time to chime in :) ) > > > > > > We're very close to being able to split all of the tests out of mobile > > > spec; we have a test runner which is close to being ready that will > pull > > in > > > tests from individual plugins. Once that's ready, we'll be able to move > > the > > > tests from MS back into plugins. > > > > > > Most plugins right now have a set of tests that was copied in circa > > Cordova > > > 2.9/3.0, and so they'll mostly need to be refreshed when we finally > move > > to > > > plugin-hosted-tests. > > > > > > (And I think the tests are back to passing now, from the look of the CI > > > dashboard -- thanks for doing that! :) ) > > > > > > Ian > > > > > > > > > > > > > > > On Wed, Jan 8, 2014 at 3:23 PM, Jesse <purplecabb...@gmail.com> wrote: > > > > > > > I reverted the merge and pushed to master. > > > > > > > > So should the mobile-spec tests, or the tests in each plugin repo be > > > > considered the root? I fear they are out of sync. > > > > > > > > @purplecabbage > > > > risingj.com > > > > > > > > > > > > On Wed, Jan 8, 2014 at 10:54 AM, Jesse <purplecabb...@gmail.com> > > wrote: > > > > > > > > > I did the premature merge for CB-5602, I'll revert it. > > > > > > > > > > @purplecabbage > > > > > risingj.com > > > > > > > > > > > > > > > On Wed, Jan 8, 2014 at 8:47 AM, Ian Clelland < > iclell...@chromium.org > > > > >wrote: > > > > > > > > > >> I think that this has to do with CB-5602. It looks like the file > api > > > > tests > > > > >> were overwritten with a version from the cordova-plugin-file repo, > > > which > > > > >> would have been rather stale, and the merge caused the whole suite > > to > > > > >> contain errors. > > > > >> > > > > >> We appear to have a completely different issue in the CI server, > > > because > > > > >> the tests should have failed on all platforms, not just > iOS/release. > > > > >> > > > > >> [I've replied to CB-5602 as well; not sure which is the better > place > > > for > > > > >> discussion] > > > > >> > > > > >> Ian > > > > >> > > > > >> > > > > >> > > > > >> On Wed, Jan 8, 2014 at 11:08 AM, David Kemp <drk...@chromium.org> > > > > wrote: > > > > >> > > > > >> > Unfortunately, our iOS deploy has been broken for a while. I > just > > > > spent > > > > >> > some time getting it back on its feet and find that master does > > not > > > > pass > > > > >> > tests. I do not have a simple 'blame list' because many commits > > have > > > > >> passed > > > > >> > since the test deployed correctly. > > > > >> > > > > > >> > All tests pass on iOS 3.3.x > > > > >> > > > > > >> > All tests pass on Android Master and 3.3.x > > > > >> > > > > > >> > On iOS master 7 file tests are failing on iOS 6.1.3 and 7.04 > > > > >> > > > > > >> > > > > > >> > "*spec*": "File API DirectoryEntry file.spec.25 > > > > >> > DirectoryEntry.getDirectory: create new dir with space > > > > >> resolveFileSystemURI > > > > >> > with encoded URI.", > > > > >> > > > > > >> > "*exception*": "timeout: timed out after > > 7500 > > > > >> msec > > > > >> > waiting for win never called", > > > > >> > > > > > >> > "*spec*": "File API File file.spec.40 should be > > > define > > > > >> File > > > > >> > attributes.", > > > > >> > > > > > >> > "*exception*": "Expected undefined to be > > > > >> defined.", > > > > >> > > > > > >> > "*spec*": "File API Entry file.spec.63 copyTo: > > > > directory > > > > >> > that does not exist.", > > > > >> > > > > > >> > "*exception*": "TypeError: 'null' is not > an > > > > >> object > > > > >> > (evaluating 'parent.filesystem.__format__') in > > > > >> > > > > > >> > > > > > >> > > > > > > > > > > file:///var/mobile/Applications/836872AD-CFED-4BE7-A316-45353151C586/mobilespec.app/www/plugins/org.apache.cordova.file/www/Entry.js > > > > >> > (line 165)", > > > > >> > > > > > >> > "*exception*": "timeout: timed out after > > 7500 > > > > >> msec > > > > >> > waiting for itCopy never called", > > > > >> > > > > > >> > "*spec*": "File API Entry file.spec.79 moveTo: > > > > directory > > > > >> > that does not exist.", > > > > >> > > > > > >> > "*exception*": "timeout: timed out after > > 7500 > > > > >> msec > > > > >> > waiting for itMove never called", > > > > >> > > > > > >> > "*spec*": "File API read method file.spec.82 > should > > > > error > > > > >> > out on non-existent file.", > > > > >> > > > > > >> > "*exception*": "timeout: timed out after > > 7500 > > > > >> msec > > > > >> > waiting for verifier never called", > > > > >> > > > > > >> > "*spec*": "File API FileWriter file.spec.97 > should > > be > > > > >> able > > > > >> > to write and append to file, File object.", > > > > >> > > > > > >> > "*exception*": "timeout: timed out after > > 7500 > > > > >> msec > > > > >> > waiting for verifier", > > > > >> > > > > > >> > "*spec*": "File API Backwards compatibility > > > > file.spec.109 > > > > >> > should be able to resolve a file:/// URL.", > > > > >> > > > > > >> > "*exception*": "ReferenceError: Can't > find > > > > >> variable: > > > > >> > joinURL in > > > > >> > > > > > >> > > > > > >> > > > > > > > > > > file:///var/mobile/Applications/836872AD-CFED-4BE7-A316-45353151C586/mobilespec.app/www/autotest/tests/file.tests.js > > > > >> > (line 3599)", > > > > >> > > > > > >> > > > > > > > > > > > > > > > > > > > >
